Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix catalog modals #5729

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Fix catalog modals #5729

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f42b0dc
Fix catalog modals
abelemlih Jun 22, 2022
584ed41
Update facet.html.erb
abelemlih Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/catalog/_facet_limit.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<% unless paginator.last_page? || params[:action] == "facet" %>
<li class="more_facets_link">
<%= link_to t("more_#{field_name}_html", scope: 'blacklight.search.facets', default: :more_html, field_name: facet_field_label(facet_field.field).pluralize),
search_facet_path(id: facet_field.key), class: "more_facets_link" %>
search_facet_path(id: facet_field.key), class: "more_facets_link", data: { blacklight_modal: 'trigger' } %>
</li>
<% end %>
</ul>
18 changes: 18 additions & 0 deletions app/views/catalog/facet.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<%# Blacklight 7.24.0 %>
<%# Override app/views/catalog/facet.html.erb %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you call out which line(s) are being overridden in the comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two comments that specify the changes I made to the original file from Blacklight

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


<%= render Blacklight::System::ModalComponent.new do |component| %>
<% component.title { facet_field_label(@facet.key) } %>

<%= render partial: 'facet_index_navigation' if @facet.index_range && @display_facet.index? %>

<div class="facet-extended-list">
<%= render_facet_limit(@display_facet, layout: false) %>
</div>

<div class="container">
<div class="facet-pagination bottom row justify-content-between">
<%= render :partial=>'facet_pagination' %>
</div>
</div>
<% end %>