Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix catalog modals #5729

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Fix catalog modals #5729

merged 2 commits into from
Jun 23, 2022

Conversation

abelemlih
Copy link
Contributor

Fixes #5714

This PR does the following:

  • Ensure the modal appears correctly in the same page
  • Ensure the modal header does not include a duplicate of the pagination view, by overriding the facet view from Blacklight

Please refer to the following screenshots:

Screen Shot 2022-06-22 at 6 08 13 PM

Screen Shot 2022-06-22 at 6 07 33 PM

@abelemlih abelemlih requested a review from bwatson78 June 22, 2022 22:09
@@ -0,0 +1,18 @@
<%# Blacklight 7.24.0 %>
<%# Override app/views/catalog/facet.html.erb %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you call out which line(s) are being overridden in the comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two comments that specify the changes I made to the original file from Blacklight

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abelemlih abelemlih requested a review from bwatson78 June 23, 2022 15:47
@@ -0,0 +1,18 @@
<%# Blacklight 7.24.0 %>
<%# Override app/views/catalog/facet.html.erb %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bwatson78 bwatson78 merged commit 7abb667 into bl7boot4rails6 Jun 23, 2022
@bwatson78 bwatson78 deleted the abel-fix_catalog_modals branch June 23, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants