Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make search string used to look up objects configurable #884

Merged
merged 9 commits into from
Nov 29, 2023

Conversation

orangewolf
Copy link
Member

@orangewolf orangewolf commented Nov 9, 2023

Release Notes

This PR requires anyone with custom code that creates an ObjectFactory or that overrides the ObjectFactory#initializer or ObjectFactory#search_by_identifier methods to update their code to take in to account the new work_identifier_search_field

Resolves #867 and #866

@orangewolf orangewolf added enhancement for release notes (New feature or request) breaking-change for release notes labels Nov 9, 2023
@orangewolf orangewolf added the major-ver for release notes label Nov 9, 2023
@@ -124,7 +124,7 @@ namespace :bulkrax do
end

def make_new_exports
Bulkrax::Exporter.all.each { |e| Bulkrax::ExporterJob.perform_later(e.id) }
Bulkrax::Exporter.find_each { |e| Bulkrax::ExporterJob.perform_later(e.id) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

* main:
  unpin dry-monads. its not a dependency of bulkrax (#885)
@jeremyf jeremyf merged commit 519b377 into main Nov 29, 2023
5 checks passed
@jeremyf jeremyf deleted the configurable_search_string branch November 29, 2023 20:39
jeremyf added a commit that referenced this pull request Jan 24, 2024
* main: (24 commits)
  Retry and delete take 2 (#894)
  🎁 Add `Bulkrax.persistence_adapter` (#895)
  💸 Mint v6.0.1 (#892)
  🐛 Fix #work_identifier_search_field logic (#891)
  💸 Bump to v6.0.0 (#889)
  make search string used to look up objects configurable (#884)
  💸 v5.5.0 (#888)
  unpin dry-monads. its not a dependency of bulkrax (#885)
  fix syntax error in ERB (#883)
  add support for Rails 6, Hyrax 4, and Blacklight 7 (#782)
  Reduce SQL calls when incrementing/decrementing run counters (#881)
  Update readme to remove references to samvera-labs (#880)
  add Compatibility section to readme (#879)
  🐛 Fix tabs for Hydra application (#875)
  Nav-tabs event scoping (#874)
  📚 Update docs in preparation for best practices seminar (#873)
  use the `GlobalID` library tooling to determine global id (#869)
  Avoid NoMethodError in Bulkrax::Importers::Controller#create. (#870)
  preparing to deploy v5.4.1 (#868)
  5.4.0-bug-fixes (#865)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change for release notes enhancement for release notes (New feature or request) major-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix the ::ActiveFedora.index_field_mapper.solr_name search
2 participants