Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the ::ActiveFedora.index_field_mapper.solr_name search #867

Closed
alishaevn opened this issue Oct 4, 2023 · 0 comments · Fixed by #884
Closed

fix the ::ActiveFedora.index_field_mapper.solr_name search #867

alishaevn opened this issue Oct 4, 2023 · 0 comments · Fixed by #884
Assignees
@orangewolf

Comments

@alishaevn
Copy link
Contributor

alishaevn commented Oct 4, 2023 •
edited
Loading

story

in v5.4.0 we are unable to import a FileSet in a csv while using the FileSet row. at least while using the default work_identifier value of :source. it keeps returning a MissingParentError error.

The root of the problem comes from ObjectFactory#search_by_identifier. commit 6473259 changed the way we find the work. that change has also caused another issue (ref: #866). we reach this method from ImportFileSetJob#find_parent_record.

I will be reverting this change in order to have working functionality for the samvera training workshop tomorrow. creating this ticket however so that we can figure out how to make the intended change work, once we have more time to look into it.

demo

in solr the version is actually source_tesim, not source_ssim (the intention). however, the call to AF gives us source_sim, which is still wrong.

screenshots Screenshot 2023-10-04 at 9 17 37 AM image
@alishaevn alishaevn mentioned this issue Oct 4, 2023
Merged
alishaevn added a commit that referenced this issue Oct 4, 2023
@alishaevn
restore our ability to properly look up works by their work_identifier
99e6716 
- ref: #866
- ref:#867
@alishaevn alishaevn mentioned this issue Oct 4, 2023
Merged
alishaevn added a commit that referenced this issue Oct 4, 2023
@alishaevn
5.4.0-bug-fixes (#865)
0e68a5e 
* restore the ability to load the "/importers" page.

there was an extra "x" in the app/views/bulkrax/importers/_oai_fields.html.erb file. it threw a syntax error when trying to create a new
importer.

* restore our ability to properly look up works by their `work_identifier`

- ref: #866
- ref:#867
@alishaevn alishaevn mentioned this issue Oct 9, 2023
Closed
@orangewolf orangewolf mentioned this issue Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orangewolf orangewolf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make search string used to look up objects configurable samvera/bulkrax
2 participants
@orangewolf @alishaevn