Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refget-openapi.yaml's Range header description #339

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

jmarshall
Copy link
Member

PR #331 noted that the text for Range in the YAML file was inconsistent with that in the specification.

While it was a Google Docs document, the specification was corrected to reflect that HTTP Range byte ranges are zero-based fully-inclusive. Update the OpenAPI description correspondingly.

Also fix typos.

While it was a Google Docs document, the specification was corrected
to reflect that HTTP Range byte ranges are zero-based fully-inclusive.
Update the OpenAPI description correspondingly.

Also fix typos.
@jmarshall
Copy link
Member Author

Also: the YAML file mentions a /ping endpoint. This is not described in the spec document. Should it be added to the spec or removed from the YAML (perhaps because it has been superseded by /sequence/service-info)?

@andrewyatz andrewyatz merged commit 98de888 into samtools:master Sep 19, 2018
@andrewyatz
Copy link
Contributor

Quite right about /ping. It's a custom endpoint I had on my implementation (the original YAML was based on my server version). It should be removed and I will get that going now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants