Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Range to be exclusive at the end in refget specification. #331

Closed
wants to merge 1 commit into from

Conversation

raskoleinonen
Copy link
Contributor

Suggestion to change Range to be exclusive at end to have the same semantics as for start and end parameters.

Excerpt from https://tools.ietf.org/html/draft-ietf-http-range-retrieval-00
Examples of the Content-Range: HTTP Response Header
The first 500 bytes:
Content-Range: bytes 0-499

Also, we should check the current wording in:
https://github.com/samtools/hts-specs/blob/master/pub/refget-openapi.yaml
name: Range
required: false
description: >-
Specify a substring as a range not using query parameters. Note
start is in Ensembl-style start coordinates i.e. the first base of a
sequence is 1 not 0 as in the start parameter. Example is 'bytes:
1-10'

@raskoleinonen raskoleinonen changed the title Update refget.md Change Range to be exclusive at the end Aug 15, 2018
@raskoleinonen raskoleinonen changed the title Change Range to be exclusive at the end Change Range to be exclusive at the end in refget specification. Aug 15, 2018
@andrewyatz andrewyatz requested a review from lairdm August 15, 2018 14:53
@andrewyatz
Copy link
Contributor

Passing this onto Matt as I think he's better to comment. However same again the commit heading should be changed to reflect what the actual change has been

@raskoleinonen
Copy link
Contributor Author

It is not straightforward to modify the commit message (https://help.github.com/articles/changing-a-commit-message/). Might be easier if you reject this pull request and I'll just create a new one,

@raskoleinonen
Copy link
Contributor Author

Closing this pull request and will create a new one with proper commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants