This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IN-105: Enabled SSL and HTTPS for Elasticsearch #69
base: master
Are you sure you want to change the base?
IN-105: Enabled SSL and HTTPS for Elasticsearch #69
Changes from all commits
be830b0
568b92d
3fb01b7
a5dfd67
cbbf3e6
e0710f1
a9c1731
018988b
eaa559a
0c64826
eb03e89
7ce716a
2c82271
5ef6f5a
3a2c7ee
85bef94
450653c
fc986ff
2ddc005
25e03bc
92ee593
d9ed56e
c6580b2
ba6730d
9a854eb
49854bf
bcc9613
3791ebc
a401b2a
0f36c39
7873cee
1aeb824
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't store this cert like this. Anyone has access, security issue.
we need to have logic that 1) checks for a stored cert (in the vault) and uses that, or 2) request a new cert if none is present and store that in the vault.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugger. It was a really elegant solution, but security trumps beauty.
I'll look into using Hashicorp Vault again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may work, but I would prefer you left this one how it was {{ .Values.name }}.{{ .Release.Namespace }} because CI may run many tests and they each have a different namespace and name...so they don't clash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I don't see this set anyplace ELASTICSEARCH_PORT_9200_TCP_ADDR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test was failing locally with the original values. We could have two URLs (e.g. $url_second or some such) and only try the second if we can't connect to the first.