Adjust nonara/ts-patch#138 #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since TypeScript v5.3 update, `tsc` no more parses `JSDocComment`s. Therefore, `typia` also cannot utilize those `JSDocComment` related features too, especially "Comment Tags" and "JSON schema generator". To reflect such TypeScript v5.3 update, `typia` has newly added a temporary CLI command `npx typia patch` that is hacking the TypeScript module to turning on the `JSDocComment` parsing. - #883 In today, `ts-patch` has started supporting the TypeScript v5.3 update by reading `package.json` of transformer libraries. Therefore, the temporary CLI command no more required. Following the `ts-patch` guide, this PR has configured the `package.json` file for `ts-patch`, and `JSDocComment` parsing would be turned on by the `ts-patch`. For reference, the temporary CLI command `npx typia patch` would be kept for a while, due to there can be some users using previous version of `ts-patch`. It would be deprecated after the next major update.
samchon
commented
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since TypeScript v5.3 update,
tscno more parsesJSDocComments. Therefore,typiaalso cannot utilize thoseJSDocCommentrelated features too, especially "Comment Tags" and "JSON schema generator".To reflect such TypeScript v5.3 update,
typiahas newly added a temporary CLI commandnpx typia patchthat is hacking the TypeScript module to turning on theJSDocCommentparsing.npx typia patchfor hackingdefaultJSDocParsingModevalue #883In today,
ts-patchhas started supporting the TypeScript v5.3 update by readingpackage.jsonof transformer libraries. Therefore, the temporary CLI command no more required. Following thets-patchguide, this PR has configured thepackage.jsonfile forts-patch, andJSDocCommentparsing would be turned on by thets-patch.For reference, the temporary CLI command
npx typia patchwould be kept for a while, due to there can be some users using previous version ofts-patch. It would be deprecated after the next major update.