-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package Config, ts 5.3, & fixes #138
Conversation
8a1461d
to
24798a5
Compare
@samchon Should be all set! You can have a look at the README for how to implement: https://github.com/nonara/ts-patch/blob/24798a5cd5bf4b511e114d622968d22e72259bc4/README.md#plugin-package-configuration I'll hold off on a release until you try it out. Seems to be working well in tests. |
Thanks for development. Which version should I use? |
Affects createProgram special instructions & tsExtras
24798a5
to
069411e
Compare
@samchon It isn't released yet, so for now to test it you can just clone this branch into a new branch on your typia dev dir. Steps:
You'll probably also want to run Please let me know when you've confirmed it works! |
This is what you'd add to typia's main "tsp": {
"tscOptions": {
"parseAllJsDoc": true
}
} To see an example project, have a look at If you get stuck, feel free to share your working branch, and I'll take a look |
@nonara As the `link:<path>` does not work and I do not know how to fix the problem, I just published temporary npm package, and proceed the testing. You can reproduce it by running the `npm run package:tgz` command, and it is not working as you can see.
Not working like above referenced commit. |
Thanks for checking it out. Protocol for yarn is I'll take a look with your branch tomorrow. What am I looking for? How will I know if it succeeds or fails? |
You can check it just by running the By the way, you should edit |
https://github.com/samchon/ts-patch-typescript-v5.3-test Here is easier repo for testing. When testing, just run below command please, with the git clone https://github.com/samchon/ts-patch-typescript-v5.3-test
cd ts-patch-typescript-v5.3-test
npm install
npm start |
@samchon Thanks! It needed a minor adjustment for package location logic, but it's working now. |
Thanks for development. I'll adjust it ASAP. |
Since TypeScript v5.3 update, `tsc` no more parses `JSDocComment`s. Therefore, `typia` also cannot utilize those `JSDocComment` related features too, especially "Comment Tags" and "JSON schema generator". To reflect such TypeScript v5.3 update, `typia` has newly added a temporary CLI command `npx typia patch` that is hacking the TypeScript module to turning on the `JSDocComment` parsing. - #883 In today, `ts-patch` has started supporting the TypeScript v5.3 update by reading `package.json` of transformer libraries. Therefore, the temporary CLI command no more required. Following the `ts-patch` guide, this PR has configured the `package.json` file for `ts-patch`, and `JSDocComment` parsing would be turned on by the `ts-patch`. For reference, the temporary CLI command `npx typia patch` would be kept for a while, due to there can be some users using previous version of `ts-patch`. It would be deprecated after the next major update.
Since TypeScript v5.3 update, `tsc` no more parses `JSDocComment`s. Therefore, `typia` also cannot utilize those `JSDocComment` related features too, especially "Comment Tags" and "JSON schema generator". To reflect such TypeScript v5.3 update, `typia` has newly added a temporary CLI command `npx typia patch` that is hacking the TypeScript module to turning on the `JSDocComment` parsing. Also, `nestia` has adopted the CLI when running the `npx nestia setup` command. - samchon/typia#883 - #696 In today, `ts-patch` has started supporting the TypeScript v5.3 update by reading `package.json` of transformer libraries. Therefore, the temporary CLI command no more required. Following the `ts-patch` guide, this PR has configured the `package.json` file for `ts-patch`, and `JSDocComment` parsing would be turned on by the `ts-patch`. For reference, the temporary CLI command `npx typia patch` would be kept for a while, due to there can be some users using previous version of `ts-patch`. It would be deprecated after the next major update.
We covered a number of issues in this PR.
Mainly, we added the ability to allow plugin packages to have special config defined within their
package.json
file under atsp
section. This allows us to tell TSP that our plugin requires full JSDoc parsing to handle the changes made in the recent 5.3 JSDoc parsing changes).We also fixed several various bugs and added support for chained transformers.