Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plasma-ui): fix Badge tests #985

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat(plasma-ui): fix Badge tests #985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/plasma-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@salutejs/plasma-ui",
"version": "1.228.0",
"description": "Salute Design System",
"description": "Salute Design System.",
"main": "index.js",
"module": "es/index.js",
"types": "index.d.ts",
Expand Down
1 change: 0 additions & 1 deletion packages/plasma-ui/src/components/Badge/BadgeBase.component-test.tsx
View file
Open in desktop

This file was deleted.

67 changes: 67 additions & 0 deletions packages/plasma-ui/src/components/Badge/BadgeBase.component-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
/* eslint-disable */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему в итоге убрали то ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тесты достаточно сильно отличались. Решили пока убрать симлинку

import React from 'react';
import { IconEye } from '@salutejs/plasma-icons';

import { mount, CypressTestDecorator, getComponent, PadMe, SpaceMe } from '@salutejs/plasma-cy-utils';

const Icon = () => <IconEye color="inherit" size="xs" />;

describe('plasma-core: Badge', () => {
const Badge = getComponent('Badge');

it('simple', () => {
mount(
<CypressTestDecorator>
<Badge text="Badge" />
</CypressTestDecorator>,
);

cy.matchImageSnapshot();
});

it('with Icon', () => {
mount(
<CypressTestDecorator>
<Badge text="Badge" contentLeft={<Icon />} />
<PadMe />
<Badge contentLeft={<Icon />} />
</CypressTestDecorator>,
);

cy.matchImageSnapshot();
});

it('_sizes', () => {
mount(
<CypressTestDecorator>
<Badge text="Badge_size_l" size="l" contentLeft={<Icon />} />
<PadMe />
<Badge text="Badge_size_s" size="s" contentLeft={<Icon />} />
<PadMe />
</CypressTestDecorator>,
);

cy.matchImageSnapshot();
});

it('_circled', () => {
mount(
<CypressTestDecorator>
circled :
<SpaceMe />
<Badge circled size="l" text="18" />
<SpaceMe />
<Badge circled size="s" text="18" />
<PadMe />
simple :
<SpaceMe />
<Badge size="l" text="18" />
<SpaceMe />
<Badge size="s" text="18" />
<PadMe />
</CypressTestDecorator>,
);

cy.matchImageSnapshot();
});
});
1 change: 0 additions & 1 deletion packages/plasma-ui/src/components/Slider/Slider.component-test.tsx
View file
Open in desktop

This file was deleted.

257 changes: 257 additions & 0 deletions packages/plasma-ui/src/components/Slider/Slider.component-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,257 @@
import React, { useState } from 'react';
import { mount, CypressTestDecorator, getComponent, PadMe, Portal } from '@salutejs/plasma-cy-utils';

const noop = () => {};

const dragAndDrop = (chainableSelector: Cypress.Chainable, coord: { clientX: number; clientY: number }) => {
chainableSelector.trigger('mousedown').trigger('mousemove', coord).trigger('mouseup');
};

describe('plasma-core: Slider', () => {
const Slider = getComponent('Slider');
const Badge = getComponent('Badge');
const sliderThumbSelector = 'div > div + div > div';

it('default', () => {
mount(
<CypressTestDecorator>
<Slider value={42} min={0} max={100} />
</CypressTestDecorator>,
);

cy.matchImageSnapshot();
});

it('default: focus', () => {
mount(
<CypressTestDecorator>
<Slider value={24} min={0} max={100} />
</CypressTestDecorator>,
);

cy.get(sliderThumbSelector).focus();

cy.matchImageSnapshot();
});

it('with portal', () => {
const PORTAL_ROOT_ID = 'portal-root';

mount(
<CypressTestDecorator>
<>
<div id={PORTAL_ROOT_ID}>
<Badge view="primary" transparent text="Slider in Portal" />
</div>
<Portal id={PORTAL_ROOT_ID}>
<Slider value={30} min={0} max={100} />
</Portal>
</>
</CypressTestDecorator>,
);

cy.matchImageSnapshot();
});

it('_disabled', () => {
mount(
<CypressTestDecorator>
<Slider disabled value={42} min={0} max={100} />
</CypressTestDecorator>,
);

cy.get(sliderThumbSelector).focus();

cy.matchImageSnapshot();
});

it('double', () => {
mount(
<CypressTestDecorator>
<Slider value={[13, 42]} min={0} max={100} />
</CypressTestDecorator>,
);

cy.matchImageSnapshot();
});

it('drag and drop with single', () => {
mount(
<CypressTestDecorator>
<Slider onChange={noop} onChangeCommitted={noop} value={50} min={0} max={100} />
</CypressTestDecorator>,
);

dragAndDrop(cy.root(), { clientX: 350, clientY: 15 });

cy.root().click(270, 15);

cy.matchImageSnapshot();
});

it('drag and drop without onChange', () => {
mount(
<CypressTestDecorator>
<Slider onChangeCommitted={noop} value={[0, 50]} min={0} max={100} />
<PadMe />
<Slider onChangeCommitted={noop} value={50} min={0} max={100} />
</CypressTestDecorator>,
);

dragAndDrop(cy.root().get('div > div + div').first(), { clientX: 50, clientY: 15 });

cy.root().click(350, 15);

cy.root().click(350, 45);

cy.matchImageSnapshot();
});

it('drag and drop with double', () => {
mount(
<CypressTestDecorator>
<Slider onChange={noop} onChangeCommitted={noop} value={[25, 75]} min={0} max={100} />
</CypressTestDecorator>,
);

dragAndDrop(cy.root().get('div > div + div').first(), { clientX: 50, clientY: 15 });

dragAndDrop(cy.root().get('div > div + div').last(), { clientX: 450, clientY: 15 });

cy.matchImageSnapshot();
});

describe('Keyboard support', () => {
const props = {
max: 100,
min: 0,
};

const ariaValueNow = 'aria-valuenow';
const ariaValueMax = 'aria-valuemax';
const ariaValueMin = 'aria-valuemin';
const defaultSliderValue = 20;

function StubComponent({ value = defaultSliderValue }: { value?: number | number[] }) {
const [state, setState] = useState(value);

const onChangeCommittedHandle = (values) => {
setState(values);
};

return <Slider onChangeCommitted={onChangeCommittedHandle} value={state} {...props} />;
}

it('increase value by ArrowRight, ArrowUp', () => {
const countRepeat = 2;

mount(
<CypressTestDecorator>
<StubComponent />
</CypressTestDecorator>,
);

cy.get(sliderThumbSelector)
.focus()
.should('have.attr', ariaValueNow, defaultSliderValue)
.type('{rightArrow}'.repeat(countRepeat))
.should('have.attr', ariaValueNow, defaultSliderValue + countRepeat)
.type('{upArrow}'.repeat(countRepeat))
.should('have.attr', ariaValueNow, defaultSliderValue + countRepeat * 2);
});

it('decrease value by ArrowLeft, ArrowDown', () => {
const countRepeat = 2;

mount(
<CypressTestDecorator>
<StubComponent />
</CypressTestDecorator>,
);

cy.get(sliderThumbSelector)
.focus()
.should('have.attr', ariaValueNow, defaultSliderValue)
.type('{leftArrow}'.repeat(countRepeat))
.should('have.attr', ariaValueNow, defaultSliderValue - countRepeat)
.type('{downArrow}'.repeat(countRepeat))
.should('have.attr', ariaValueNow, defaultSliderValue - countRepeat * 2);
});

it('change value by Home, End', () => {
mount(
<CypressTestDecorator>
<StubComponent />
</CypressTestDecorator>,
);

cy.get(sliderThumbSelector)
.focus()
.should('have.attr', ariaValueNow, defaultSliderValue)
.type('{end}')
.should('have.attr', ariaValueNow, props.max)
.type('{home}')
.should('have.attr', ariaValueNow, props.min);
});

it('processing multiple steps by PageUp, PageDown', () => {
mount(
<CypressTestDecorator>
<StubComponent />
</CypressTestDecorator>,
);

const multipleSteps = props.max * 0.1;

cy.get(sliderThumbSelector)
.focus()
.should('have.attr', ariaValueNow, defaultSliderValue)
.type('{pageUp}')
.should('have.attr', ariaValueNow, defaultSliderValue + multipleSteps)
.type('{pageDown}')
.should('have.attr', ariaValueNow, defaultSliderValue);
});

it('Double slider', () => {
mount(
<CypressTestDecorator>
<StubComponent value={[25, 75]} />
</CypressTestDecorator>,
);

cy.get(sliderThumbSelector)
.first()
.focus()
.should('have.attr', ariaValueNow, 25)
.should('have.attr', ariaValueMin, props.min)
.type('{end}')
.should('have.attr', ariaValueMax, 75)
.type('{home}')
.should('have.attr', ariaValueNow, props.min)
.type('{rightArrow}'.repeat(10));

cy.get(sliderThumbSelector)
.last()
.focus()
.type('{end}')
.should('have.attr', ariaValueMax, props.max)
.type('{home}')
.invoke('attr', ariaValueNow)
.then((state) => {
// INFO: Проверяем, что максимальное значение первого слайдера ограничено текущем значением второго
cy.get(sliderThumbSelector).first().should('have.attr', ariaValueMax, state);
});

// INFO: Проверяем, что минимальное значение второго слайдера ограничено текущем значением первого
cy.get(sliderThumbSelector)
.last()
.focus()
.invoke('attr', ariaValueMin)
.then((state) => {
cy.get(sliderThumbSelector).first().should('have.attr', ariaValueNow, state);
});

cy.matchImageSnapshot();
});
});
});
Loading