Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-ui): fix Badge tests #985

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat(plasma-ui): fix Badge tests #985

merged 1 commit into from
Jan 19, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Jan 19, 2024 •
edited by Salute-Eva
Loading

Badge

  • Поправлены тесты Badge для ui

What/why changed

В plasma-ui падали тесты так как они были симлинкой на plasma-core. Заменили на обычные файлы.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Jan 19, 2024
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-985/

@TitanKuzmich TitanKuzmich force-pushed the plasma/fix-badge-ui-tests branch from 77a8b70 to b13596d Compare January 19, 2024 08:46
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-985/

@TitanKuzmich TitanKuzmich added changelog-skip Exclude pull request changes from changelog and removed plasma-components labels Jan 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma/fix-badge-ui-tests branch from b13596d to a06c508 Compare January 19, 2024 10:38
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-985/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-985/
ui storybook: http://plasma.sberdevices.ru/pr/pr-985/ui-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-985/temple-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Jan 19, 2024
Merged via the queue into dev with commit 5ec2283 Jan 19, 2024
23 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma/fix-badge-ui-tests branch January 19, 2024 11:23
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Yeti-or
Yeti-or reviewed Jan 19, 2024
View reviewed changes
packages/plasma-ui/src/components/Badge/BadgeBase.component-test.tsx
@@ -1 +0,0 @@
../../../../plasma-core/src/components/Badge/Badge.component-test.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему в итоге убрали то ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тесты достаточно сильно отличались. Решили пока убрать симлинку

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yeti-or Yeti-or Yeti-or left review comments

@neretin-trike neretin-trike neretin-trike approved these changes

@Yakutoc Yakutoc Yakutoc approved these changes

Assignees

@TitanKuzmich TitanKuzmich

Labels
changelog-skip Exclude pull request changes from changelog prerelease
Projects
Plasma
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TitanKuzmich @Salute-Eva @Yeti-or @Yakutoc @neretin-trike