Normalize package names once on using pkg.installed/removed with yum #62029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
vzhestkov
force-pushed
the
normalize-package-names-once
branch
3 times, most recently
from
3dbf0b2
to
59f4815
Compare
This was referenced May 11, 2022
vzhestkov
force-pushed
the
normalize-package-names-once
branch
5 times, most recently
from
aeecf84
to
48b7054
Compare
vzhestkov
force-pushed
the
normalize-package-names-once
branch
3 times, most recently
from
d7a0c3d
to
4b5ee39
Compare
vzhestkov
force-pushed
the
normalize-package-names-once
branch
5 times, most recently
from
4598c43
to
a8e4b97
Compare
twangboy
previously approved these changes
Oct 12, 2022
Ch3LL
suggested changes
Oct 13, 2022
vzhestkov
force-pushed
the
normalize-package-names-once
branch
from
30344b1
to
c73620f
Compare
Ch3LL
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On using
pkg.installedorpkg.removedthe package name normalization performed few times causing removing valid package name parts looks similar to ARCH name.For example on trying to install the package
uptrack-updates-4.14.35-2047.502.4.el7uek.x86_64-20220207-0.noarchit's possible thatx86_64will be wiped from the package name as it matches the name of the ARCH but actually the part of the name of the package. As the result it causingyumto return the error as it's unable to find the package with nameuptrack-updates-4.14.35-2047.502.4.el7uekPrevious Behavior
Impossible to install the packages with ARCH specified in the name of the package.
New Behavior
It's possible to install such packages.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.