Normalize package names once with pkg.installed/removed using yum (bsc#1195895) - 3000 #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhestkov
changed the title
vzhestkov
force-pushed
the
fix-pkg-for-weird-names-3000
branch
from
05ff303
to
96df577
Compare
vzhestkov
force-pushed
the
fix-pkg-for-weird-names-3000
branch
from
96df577
to
6c8f98f
Compare
vzhestkov
changed the title
vzhestkov
force-pushed
the
fix-pkg-for-weird-names-3000
branch
4 times, most recently
from
10ff660
to
12c5a00
Compare
vzhestkov
force-pushed
the
fix-pkg-for-weird-names-3000
branch
from
12c5a00
to
7badbdf
Compare
vzhestkov
changed the title
Merged
3 tasks
vzhestkov
changed the title
This was referenced May 11, 2022
meaksh
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On calling
pkg.installedorpkg.removedthe package name normalisation is performing few timess.As the result it leads to removing
.ARCHif used in the name of the package as suffix, but actually a part of the name.What issues does this PR fix or reference?
Fixes: https://github.com/SUSE/spacewalk/issues/16974
Upstream PR: saltstack/salt#62029
Previous Behavior
Error on trying to install/remove the packages with such names:
uptrack-updates-4.14.35-2047.502.4.el7uek.x86_64(x86_64is not an arch there, but a part of the name, the arch of this package isnoarch)weird-name-1.2.3-1234.5.6.test7tst.x86_64-20220214-2.1.noarch(wherenoarchthe real package arch andx86_64is a part of the name)New Behavior
No errors on installing/removing the package
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.