Transport Refactor

[dwoz]

Requires #60852

What does this PR do?

What issues does this PR fix or reference?

Fixes:

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[dwoz]

re-run all

[devkits]

I am updating the Rabbit POC to match the latest code in this branch.
Wondering whether salt/salt/cli/caller.py needs to be updated in this branch as well so that a new caller can be implemented with a new transport.

[devkits]

A few general questions/comments:

1. self.event.fire_event() seems to use the hard-coded salt.transport.ipc.IPCMessageClient which, in turn, uses local IPC primitives. Do we expect this to work side-by-side with broker-based event bus where there may not be any sockets or streams?

2. FYI: following the text pattern search [ "zeromq", "tcp" ], a few additional files that I had to modify to fit in rabbitmq:

• salt/moduls/mine.py
• salt/utils/minions.py
• salt/utils/minion.py
• salt/modules/publish.py
• salt/output/key.py
• salt/cli/caller.py
• noxfile.py

[damon-atkins]

Will this change require the master and minion to be upgraded at the same time?
If so consider allowing the minion to discover what protocol the Master is using. Like SSH and TLS which both have a little bit of communication in the clear first.

read A < /dev/tcp/localhost/22 ; echo $A
SSH-2.0-OpenSSH_9.7

[damon-atkins]

@devkits is the RabbitMQ code, allow for the RabbitMQ to run on a different server to the master?

[dwoz]

re-run full all

[waynew]

What a job! Nice work on this refactor!

A couple of questions/typos in docstrings, but I think there's a typo in thin.py that's a proper bug.

[dwoz]

re-run full all

[github-actions]

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)

Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 1.69s
- exit code: 1
The function 'recv' on 'salt/modules/cp.py' does not have a 'CLI Example:' in it's docstring

The function 'recv_chunked' on 'salt/modules/cp.py' does not have a 'CLI Example:' in it's docstring

The function 'envs' on 'salt/modules/cp.py' does not have a 'CLI Example:' in it's docstring

Found 3 errors

---

Thanks again!

[dwoz]

re-run full all

[dwoz]

Replaced by #61450