Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transport singletons #60852

Merged
merged 7 commits into from
Sep 15, 2021
Merged

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Sep 8, 2021

What does this PR do?

Remove un-needed singletons from transports.

What issues does this PR fix or reference?

Fixes: #60851

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

@dwoz dwoz requested a review from a team as a code owner September 8, 2021 00:44
@dwoz dwoz requested review from xeacott and removed request for a team September 8, 2021 00:44
@dwoz dwoz marked this pull request as draft September 8, 2021 00:44
@dwoz dwoz changed the title Remove singletons [WIP] Remove singletons Sep 8, 2021
@dwoz dwoz marked this pull request as ready for review September 8, 2021 23:08
@dwoz dwoz changed the title [WIP] Remove singletons Remove transport singletons Sep 8, 2021
@dwoz dwoz added the Silicon v3004.0 Release code name label Sep 8, 2021
@dwoz dwoz requested a review from s0undt3ch September 9, 2021 04:45
s0undt3ch
s0undt3ch previously approved these changes Sep 9, 2021
@dwoz
Copy link
Contributor Author

dwoz commented Sep 9, 2021

re-run full all

@dwoz
Copy link
Contributor Author

dwoz commented Sep 10, 2021

re-run full all

@dwoz dwoz mentioned this pull request Sep 12, 2021
3 tasks
@garethgreenaway garethgreenaway merged commit 8b2df33 into saltstack:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Silicon v3004.0 Release code name
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TECH DEBT] Remove singletons from zeromq and tcp transports
5 participants