Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semantic-release): implement for this formula #44

Merged

Commits on Oct 26, 2019

  1. fix(yamllint): fix all errors

    ```bash
    ntp-formula$ yamllint -s .
    ./pillar.example
      1:1       warning  missing document start "---"  (document-start)
      11:1      error    duplication of key "ntp" in mapping  (key-duplicates)
      15:1      error    duplication of key "ntp" in mapping  (key-duplicates)
      21:1      error    duplication of key "ntp" in mapping  (key-duplicates)
      24:4      error    syntax error: found character '%' that cannot start any token
      25:89     error    line too long (92 > 88 characters)  (line-length)
    ```
    myii committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    3c329df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    88ac182 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. Configuration menu
    Copy the full SHA
    250ee2c View commit details
    Browse the repository at this point in the history
  2. fix(container): respect ConditionVirtualization service setting

    * E.g. `opensuse-leap-151`:
    
    ```bash
    kitchen@0e066e43d255:~> systemctl status ntpd
    WARNING: terminal is not fully functional
    -  (press RETURN)● ntpd.service - NTP Server Daemon
       Loaded: loaded (/usr/lib/systemd/system/ntpd.service; enabled; vendor preset: disabled)
       Active: inactive (dead)
    Condition: start condition failed at Sat 2019-10-26 04:11:32 UTC; 13min ago
               └─ ConditionVirtualization=!container was not met
         Docs: man:ntpd(1)
    ```
    
    * Check for `Docker` for the time being (other containers _are_ possible) --
      replace earlier method of checking for the `kitchen` user:
      - `salt['environ.get']('SUDO_USER', '') == 'kitchen'`
    myii committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    8711b24 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    55b8f61 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7094dae View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    598da25 View commit details
    Browse the repository at this point in the history