feat(semantic-release): implement for this formula #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```bash ntp-formula$ yamllint -s . ./pillar.example 1:1 warning missing document start "---" (document-start) 11:1 error duplication of key "ntp" in mapping (key-duplicates) 15:1 error duplication of key "ntp" in mapping (key-duplicates) 21:1 error duplication of key "ntp" in mapping (key-duplicates) 24:4 error syntax error: found character '%' that cannot start any token 25:89 error line too long (92 > 88 characters) (line-length) ```
myii
force-pushed
the
feat/implement-semantic-release
branch
from
e1724cd
to
d27e896
Compare
* E.g. `opensuse-leap-151`:
```bash
kitchen@0e066e43d255:~> systemctl status ntpd
WARNING: terminal is not fully functional
- (press RETURN)● ntpd.service - NTP Server Daemon
Loaded: loaded (/usr/lib/systemd/system/ntpd.service; enabled; vendor preset: disabled)
Active: inactive (dead)
Condition: start condition failed at Sat 2019-10-26 04:11:32 UTC; 13min ago
└─ ConditionVirtualization=!container was not met
Docs: man:ntpd(1)
```
* Check for `Docker` for the time being (other containers _are_ possible) --
replace earlier method of checking for the `kitchen` user:
- `salt['environ.get']('SUDO_USER', '') == 'kitchen'`
* Automated using myii/ssf-formula#87
myii
force-pushed
the
feat/implement-semantic-release
branch
from
d27e896
to
598da25
Compare
|
Nice @myii |
|
Thanks. |
|
🎉 This PR is included in version 0.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
ntp-formulamyii/ssf-formula#87Describe the changes you're proposing
semantic-releasePRs do not modify the functionality of the formula itself. The exception in this case is that testing revealed the issue with thentpservice not running in a container foropensuse. So this is checked for in the formula and the tests are structured accordingly.Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context