Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Barefoot platform module for Bullseye and 5.10 kernel #8

Conversation

KostiantynYarovyiBf
Copy link

@KostiantynYarovyiBf KostiantynYarovyiBf commented Oct 22, 2021

Why I did it

Update Barefoot platform support for Bullseye and 5.10 kernel

How I did it

  1. modify Barefoot platform driver for linux 5.10
  2. add python3-venv for bullseye

How to verify it

build image with kernel 5.10 and verify on Barefoot board

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@KostiantynYarovyiBf KostiantynYarovyiBf marked this pull request as ready for review October 26, 2021 17:14
@KostiantynYarovyiBf KostiantynYarovyiBf force-pushed the bullseye-upgrade-barefoot-bfn-moduls branch from f6dbe95 to 039c788 Compare October 27, 2021 10:04
@saiarcot895
Copy link
Owner

What's the purpose of python3-venv? Will Arista's Python scripts need to be run in a virtualenv?

@saiarcot895 saiarcot895 force-pushed the bullseye-upgrade-base branch 4 times, most recently from 1d32c05 to f55f961 Compare November 2, 2021 06:49
@saiarcot895
Copy link
Owner

Also, is the submodule update for Arista still needed? I recall seeing some comments on a PR saying that the necessary changes were already done.

@saiarcot895
Copy link
Owner

Manually merged in everything except for the submodule update; recent commits suggest that it's not needed, and a local build for Arista on Broadcom succeeded without the submodule change.

@saiarcot895 saiarcot895 closed this Nov 2, 2021
saiarcot895 pushed a commit that referenced this pull request Nov 3, 2021
Update Barefoot platform support for Bullseye and 5.10 kernel, and add
python3-venv.
@KostiantynYarovyiBf
Copy link
Author

KostiantynYarovyiBf commented Nov 3, 2021

Manually merged in everything except for the submodule update; recent commits suggest that it's not needed, and a local build for Arista on Broadcom succeeded without the submodule change.

I update submodule on latest master (hash d82bb20) according to discussion on this PR:
aristanetworks/sonic#32
It necessary for build on Barefoot.

How to verified:

  1. make init
  2. make configure PLATFORM=barefoot
  3. make all
  4. make target/sonic-aboot-barefoot.swi
  5. deploy sonic on Arista test bed and check syncd container after 3 mins (docker ps -a)
  6. or check show interface status and so on.
    Without this fix interfaces will be absent, syncd crashed.

Also the latest commits are necessary for successful build Sonic Barefoot.

P.s. Sorry for the late reply

@KostiantynYarovyiBf
Copy link
Author

What's the purpose of python3-venv? Will Arista's Python scripts need to be run in a virtualenv?

I'll double-check this without python3-venv

saiarcot895 pushed a commit that referenced this pull request Nov 9, 2021
Update Barefoot platform support for Bullseye and 5.10 kernel, and add
python3-venv.
saiarcot895 pushed a commit that referenced this pull request Nov 11, 2021
Update Barefoot platform support for Bullseye and 5.10 kernel, and add
python3-venv.
saiarcot895 pushed a commit that referenced this pull request Dec 10, 2021
#### What I did 

[sonic-linkmgrd][master] submodule update

6c6151b Fix unstable unit tests (state change handler wasn't invoked) (#8)
2f7dc0a support code diff coverage (#5)
83f0002 Force mux state switch to standby if triggered from Cli (#6)

signed-off-by: Jing Zhang [email protected]
saiarcot895 pushed a commit that referenced this pull request Jan 20, 2022
6c6151b Fix unstable unit tests (state change handler wasn't invoked) (#8)
2f7dc0a support code diff coverage (#5)
83f0002 Force mux state switch to standby if triggered from Cli (#6)

signed-off-by: Jing Zhang [email protected]
saiarcot895 pushed a commit that referenced this pull request Jan 25, 2022
* [BFN] Updated platform APIs impl

Signed-off-by: Andriy Kokhan <[email protected]>

* Extended BFN platform SFP APIs implementation

* Update sfp.py

* [BFN] Extended SFP platform plugin implementation

Signed-off-by: Andriy Kokhan <[email protected]>

* [BFN] Extended Fans platform plugin implementation

* [BFN] divided classes Fan and  FanDrawer into 2 files

* Signed-off-by: Vadym Yashchenko <[email protected]>

What I did
	Add get_model() function
	Add get_low_critical_threshold() function
	Change __get(...) function.
How I did it
	Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API

* Add get_presence() function and revised __get() function

Signed-off-by: Vadym Yashchenko <[email protected]>

* [BFN] Updated PSU platform APIs impl

Signed-off-by: Dmytro Lytvynenko <[email protected]>

* Added BFN PSU cache (#9)

Signed-off-by: Andriy Kokhan <[email protected]>

* [BFN]  Fans and Fantray platform APIs update (#7)

* [BFN] Updated SFP platform APIs (#10)

Signed-off-by: Volodymyr Boyko <[email protected]>

* [BFN] Updated platform API for thermal (#8)

* Signed-off-by: Vadym Yashchenko <[email protected]>

* Revert "[BFN]  Fans and Fantray platform APIs update (#7)" (#11)

This reverts commit c62a733.

* Add support health monitor system (#15)

Signed-off-by: Petro Bratash <[email protected]>

* Update chassis.py

* [BFN] Updated FANs and FAN Tray platform API (#14)

* Fix fix_alignment (#17)

Signed-off-by: Petro Bratash <[email protected]>

* [BFN] Improvement show environment (#16)

* Added PSU temperature skip into platform.json (#18)

Signed-off-by: Andriy Kokhan <[email protected]>

* Do not skip psud on Newport

Signed-off-by: Andriy Kokhan <[email protected]>

* [BFN] fix fan status from Not OK to Ok (#19)

* [BFN] Updated SFP platform plugin (#13)

Signed-off-by: Volodymyr Boyko <[email protected]>

* [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (#21)

Signed-off-by: Mykola Gerasymenko <[email protected]>

* [barefoot] Tmp fix vendor_rev (#22)

Signed-off-by: Volodymyr Boyko <[email protected]>

* Fixed python issues in sonic_platform/fan_drawer.py

Signed-off-by: Andriy Kokhan <[email protected]>

* Updated fan_drawer.py

* Fixing trailing white spaces in fan_drawer.py

* [BFN] Fix thrift for SFPs API

Signed-off-by: Volodymyr Boyko <[email protected]>

* In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue

Signed-off-by: Andriy Kokhan <[email protected]>

* [Newport] Thermal manager  (sonic-net#23)

* Signed-off-by: Vadym Yashchenko <[email protected]>

* Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue"

This reverts commit 1e73127.

* Removed 'controllable' options from platform.json to fix factory default config generation

Signed-off-by: Andriy Kokhan <[email protected]>

* Update thermal_manager.py

* Migrated SFP plugin to sonic_xcvr API (sonic-net#30)

Signed-off-by: Andriy Kokhan <[email protected]>

Co-authored-by: KostiantynYarovyiBf <[email protected]>
Co-authored-by: Vadym Yashchenko <[email protected]>
Co-authored-by: Dmytro Lytvynenko <[email protected]>
Co-authored-by: Volodymyr Boiko <[email protected]>
Co-authored-by: Petro Bratash <[email protected]>
Co-authored-by: Mykola Gerasymenko <[email protected]>
saiarcot895 pushed a commit that referenced this pull request Dec 20, 2024
…et#21095)

Adding the below fix from FRR FRRouting/frr#17297

This is to fix the following crash which is a statistical issue

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra -A 127.0.0.1 -s 90000000 -M dplane_fpm_nl -M snmp'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
[Current thread is 1 (Thread 0x7fccd6faf7c0 (LWP 36))]
(gdb) bt
#0  0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007fccd7302fb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x00007fccd72ed472 in abort () from /lib/x86_64-linux-gnu/libc.so.6
#3  0x00007fccd75bb3a9 in _zlog_assert_failed (xref=xref@entry=0x7fccd7652380 <_xref.16>, extra=extra@entry=0x0) at ../lib/zlog.c:678
#4  0x00007fccd759b2fe in route_node_delete (node=<optimized out>) at ../lib/table.c:352
#5  0x00007fccd759b445 in route_unlock_node (node=0x0) at ../lib/table.h:258
#6  route_next (node=<optimized out>) at ../lib/table.c:436
#7  route_next (node=node@entry=0x56029d89e560) at ../lib/table.c:410
#8  0x000056029b6b6b7a in if_lookup_by_name_per_ns (ns=ns@entry=0x56029d873d90, ifname=ifname@entry=0x7fccc0029340 "PortChannel1020")
    at ../zebra/interface.c:312
#9  0x000056029b6b8b36 in zebra_if_dplane_ifp_handling (ctx=0x7fccc0029310) at ../zebra/interface.c:1867
#10 zebra_if_dplane_result (ctx=0x7fccc0029310) at ../zebra/interface.c:2221
#11 0x000056029b7137a9 in rib_process_dplane_results (thread=<optimized out>) at ../zebra/zebra_rib.c:4810
#12 0x00007fccd75a0e0d in thread_call (thread=thread@entry=0x7ffe8e553cc0) at ../lib/thread.c:1990
#13 0x00007fccd7559368 in frr_run (master=0x56029d65a040) at ../lib/libfrr.c:1198
#14 0x000056029b6ac317 in main (argc=9, argv=0x7ffe8e5540d8) at ../zebra/main.c:478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants