Check the system R in SPKG rpy2 #38777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"make download-for-sdist" tries to download all standard sources and fails if we depend on a dummy package. Presumably fine since the r dummy package should only used at configure time.
|
We can ignore the failure of "test-new" workflow. It failed because it forced installing r_jupyter, which depends on the syetem R, which is of course not existing. |
|
Documentation preview for this PR (built with commit 12fd0db; changes) is ready! 🎉 |
…/38777/remove-r-from-dependencies
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 9, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> It is problematic to put a dummy package into the dependencies list. For instance, see sagemath#38774. We move the check for the system R to `spkg-configure.m4` of SPKG rpy2. Then we can replace R in the dependencies list with rpy2. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> sagemath#38774 (merged here) URL: sagemath#38777 Reported by: Kwankyu Lee Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is problematic to put a dummy package into the dependencies list. For instance, see #38774.
We move the check for the system R to
spkg-configure.m4of SPKG rpy2. Then we can replace R in the dependencies list with rpy2.📝 Checklist
⌛ Dependencies
#38774 (merged here)