Fix broken anchors in CHANGES.html of doc preview #38274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwankyu
changed the title
kwankyu
force-pushed
the
p/fix-changes-html
branch
from
ef578b9
to
d2d1514
Compare
kwankyu
changed the title
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 11, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> as sagemath#38220 allows us to implement the version selector to sage doc. Preview : https://doc-pr-53--sagemath- test.netlify.app/html/en/reference/ The script `sage-update-version`(used by the release manager) updates src/doc/website/versions.txt. The file will be accessible from https://doc-release--sagemath.netlify.app/html/en/versions.txt, after 10.4 release. The Preview is using https://doc-release--sagemath- test.netlify.app/html/en/versions.txt for test purpose. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> sagemath#38274 URL: sagemath#38285 Reported by: Kwankyu Lee Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broken by careless code in #38213:
which also wipes out anchors planted by
.ci/create-changes-html.sh!To reviewer: changes over #38220 is in d2d1514
Tested in : https://github.com/kwankyu/sage/actions/runs/9659812609/job/26643993813.
Try to open https://doc-pr-43--sagemath-test.netlify.app/html/en/reference/references/#hunk2 to check
📝 Checklist
⌛ Dependencies
#38220