Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate is_AlgebraicNumber, is_AlgebraicReal, is_ComplexDoubleElement, is_ComplexIntervalFieldElement, is_ComplexNumber, is_FractionField, is_FractionFieldElement, is_Integer, is_IntegerMod, is_IntegerRing, is_Rational, is_RationalField, is_RealDoubleElement, is_RealIntervalField, is_RealIntervalFieldElement, is_RealNumber #38128

Merged
merged 16 commits into from
Jun 22, 2024
Merged

Deprecate is_AlgebraicNumber, is_AlgebraicReal, is_ComplexDoubleElement, is_ComplexIntervalFieldElement, is_ComplexNumber, is_FractionField, is_FractionFieldElement, is_Integer, is_IntegerMod, is_IntegerRing, is_Rational, is_RationalField, is_RealDoubleElement, is_RealIntervalField, is_RealIntervalFieldElement, is_RealNumber #38128

merged 16 commits into from
Jun 22, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 1, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jun 1, 2024
@mkoeppe mkoeppe force-pushed the is_IntegerRing_deprecation branch 3 times, most recently from 15264ef to a6f34c3 Compare June 1, 2024 17:58
@mkoeppe mkoeppe changed the title Deprecate is_Integer etc. Deprecate is_Integer, is_IntegerMod, is_IntegerRing, is_Rational, is_RationalField, is_RealIntervalField, is_RealIntervalFieldElement Jun 1, 2024
@mkoeppe mkoeppe changed the title Deprecate is_Integer, is_IntegerMod, is_IntegerRing, is_Rational, is_RationalField, is_RealIntervalField, is_RealIntervalFieldElement Deprecate is_ComplexDoubleElement, is_ComplexIntervalFieldElement, is_ComplexNumber, is_Integer, is_IntegerMod, is_IntegerRing, is_Rational, is_RationalField, is_RealDoubleElement, is_RealIntervalField, is_RealIntervalFieldElement, is_RealNumber Jun 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024 •
edited
Loading

Documentation preview for this PR (built with commit e88d435; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe changed the title Deprecate is_ComplexDoubleElement, is_ComplexIntervalFieldElement, is_ComplexNumber, is_Integer, is_IntegerMod, is_IntegerRing, is_Rational, is_RationalField, is_RealDoubleElement, is_RealIntervalField, is_RealIntervalFieldElement, is_RealNumber Deprecate is_ComplexDoubleElement, is_ComplexIntervalFieldElement, is_ComplexNumber, is_FractionField, is_FractionFieldElement, is_Integer, is_IntegerMod, is_IntegerRing, is_Rational, is_RationalField, is_RealDoubleElement, is_RealIntervalField, is_RealIntervalFieldElement, is_RealNumber Jun 1, 2024
@mkoeppe mkoeppe changed the title Deprecate is_ComplexDoubleElement, is_ComplexIntervalFieldElement, is_ComplexNumber, is_FractionField, is_FractionFieldElement, is_Integer, is_IntegerMod, is_IntegerRing, is_Rational, is_RationalField, is_RealDoubleElement, is_RealIntervalField, is_RealIntervalFieldElement, is_RealNumber Deprecate is_AlgebraicNumber, is_AlgebraicReal, is_ComplexDoubleElement, is_ComplexIntervalFieldElement, is_ComplexNumber, is_FractionField, is_FractionFieldElement, is_Integer, is_IntegerMod, is_IntegerRing, is_Rational, is_RationalField, is_RealDoubleElement, is_RealIntervalField, is_RealIntervalFieldElement, is_RealNumber Jun 1, 2024
@mkoeppe mkoeppe marked this pull request as ready for review June 1, 2024 22:31
@mkoeppe mkoeppe force-pushed the is_IntegerRing_deprecation branch from ceab4b6 to 5e1a7bf Compare June 1, 2024 23:37
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 4, 2024

The test failure in conda (src/sage/libs/singular/function.pyx) is unrelated, I think

@mkoeppe mkoeppe requested a review from gmou3 June 6, 2024 05:53
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 6, 2024

Thank you!

Matthias Koeppe added 8 commits June 9, 2024 10:32
@mkoeppe
for a in "CLASS='FractionField';SUFFIX=_generic" "CLASS='FractionFiel…
f5387f5 
…dElement|Integer|AlgebraicReal|AlgebraicNumber|ComplexDoubleElement|ComplexIntervalFieldElement|ComplexNumber|Rational|RationalField|RealDoubleElement|RealIntervalFieldElement|RealNumber';SUFFIX=" "CLASS='IntegerRing|RealIntervalField';SUFFIX=_class" "CLASS='IntegerMod';SUFFIX=_abstract"; do eval "$a"; git --no-pager grep -l -E 'is_('$CLASS')' src/sage | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
@mkoeppe
src/sage/rings/real_mpfi.pyx: Deprecations
75573b9
@mkoeppe
Fixups
d263891
@mkoeppe
fixups
5df4553
@mkoeppe
fixups
aa68e20
@mkoeppe
src/sage/rings/real_mpfi.pyx: Deprecate is_RealIntervalField, is_Real…
61b6417 
…IntervalFieldElement
@mkoeppe
src/sage/schemes/hyperelliptic_curves/constructor.py: Use isinstance
27c0630
@mkoeppe
src/sage/rings/finite_rings/integer_mod.pyx: Deprecate is_IntegerMod
ce49874
@mkoeppe mkoeppe force-pushed the is_IntegerRing_deprecation branch from f317020 to e88d435 Compare June 9, 2024 17:32
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 10, 2024
sagemathgh-38128: Deprecate is_AlgebraicNumber, is_AlgebraicReal,…
524fcbd 
… `is_ComplexDoubleElement`, `is_ComplexIntervalFieldElement`, `is_ComplexNumber`, `is_FractionField`, `is_FractionFieldElement`, `is_Integer`, `is_IntegerMod`, `is_IntegerRing`, `is_Rational`, `is_RationalField`, `is_RealDoubleElement`, `is_RealIntervalField`, `is_RealIntervalFieldElement`, `is_RealNumber`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Fixes sagemath#24525

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38128
Reported by: Matthias Köppe
Reviewer(s): gmou3
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
sagemathgh-38128: Deprecate is_AlgebraicNumber, is_AlgebraicReal,…
98a2b16 
… `is_ComplexDoubleElement`, `is_ComplexIntervalFieldElement`, `is_ComplexNumber`, `is_FractionField`, `is_FractionFieldElement`, `is_Integer`, `is_IntegerMod`, `is_IntegerRing`, `is_Rational`, `is_RationalField`, `is_RealDoubleElement`, `is_RealIntervalField`, `is_RealIntervalFieldElement`, `is_RealNumber`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Fixes sagemath#24525

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38128
Reported by: Matthias Köppe
Reviewer(s): gmou3
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
sagemathgh-38128: Deprecate is_AlgebraicNumber, is_AlgebraicReal,…
80e07f2 
… `is_ComplexDoubleElement`, `is_ComplexIntervalFieldElement`, `is_ComplexNumber`, `is_FractionField`, `is_FractionFieldElement`, `is_Integer`, `is_IntegerMod`, `is_IntegerRing`, `is_Rational`, `is_RationalField`, `is_RealDoubleElement`, `is_RealIntervalField`, `is_RealIntervalFieldElement`, `is_RealNumber`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Fixes sagemath#24525

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38128
Reported by: Matthias Köppe
Reviewer(s): gmou3
@vbraun vbraun merged commit 3cc13a2 into sagemath:develop Jun 22, 2024
16 of 18 checks passed
@mkoeppe mkoeppe deleted the is_IntegerRing_deprecation branch June 22, 2024 20:29
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jul 8, 2024
Antonio-JP added a commit to Antonio-JP/dalgebra that referenced this pull request Jul 8, 2024
@Antonio-JP
♻️ Fixed DeprecationWarning.
7203841 
  - Changed the use of is_FractionField to isinstance(..., FractionField_generic)
  - See sagemath/sage#38128 for details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmou3 gmou3 gmou3 approved these changes

Assignees

@mkoeppe mkoeppe

Labels
t: refactoring v: large
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.

deprecate is_RealNumber, is_AlgebraicNumber, is_RealIntervalFieldElement, ...
3 participants
@mkoeppe @gmou3 @vbraun