Deprecate is_Map, is_...Morphism
#38103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 3938568; changes) is ready! 🎉 |
grhkm21
reviewed
May 28, 2024
| @@ -25,6 +25,8 @@ | |||
|
|
|||
|
|
|||
| def is_AbelianGroupMorphism(f): | |||
| from sage.misc.superseded import deprecation | |||
| deprecation(38103, "The function is_AbelianGroupMorphism is deprecated; use 'isinstance(..., AbelianGroupMorphism)' instead.") | |||
There was a problem hiding this comment.
Isn't this line too long? Why are the linters not triggering 🤔
There was a problem hiding this comment.
I've broken some of the long lines in 8619aff
added 4 commits
June 1, 2024 16:29
…ainComplexMorphism|SimplicialComplexMorphism';SUFFIX=" ; do eval "$a"; git --no-pager grep -l -E 'is_('$CLASS')' src/sage | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
…ep -l -E 'is_('$CLASS')' src/sage | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
mkoeppe
force-pushed
the
is_Map_deprecation
branch
from
8619aff
to
70614f0
Compare
|
Looks good. I assume that similar changes need to be applied for |
That was done in #38077 |
|
Oh, I see; and you did a better job than me on that. Just remove one stray import and good to go as far as I am concerned. |
|
Done |
|
Thanks for the review! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 5, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38103 Reported by: Matthias Köppe Reviewer(s): gmou3, grhkm21, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies