Allow construction of classical Lie algebras over finite fields #37773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
force-pushed
the
lie_algebras/cartan_type_pos_char
branch
from
c87157e
to
e2fc4af
Compare
fchapoton
reviewed
Apr 9, 2024
|
Documentation preview for this PR (built with commit 18487f3; changes) is ready! 🎉 |
|
This now works over |
|
Merci! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 20, 2024
…inite fields
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Many classical Lie algebras are unable to be constructed because they
multiply a rational number times an element in the base ring. If the
base ring is, say, `GF(3)`, then there is no coercion (since not every
element is defined), so we need to force all elements to be in the base
ring during the computation (which might perform a division that goes to
the fraction field, but it will eventually brings us back to a
$\mathbb{Z}$-basis).
Before, this would fail with a `QQ` to `GF(3)` coercion error:
```
sage: sl4 = lie_algebras.sl(GF(3), 4)
```
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37773
Reported by: Travis Scrimshaw
Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many classical Lie algebras are unable to be constructed because they multiply a rational number times an element in the base ring. If the base ring is, say,$\mathbb{Z}$ -basis).
GF(3), then there is no coercion (since not every element is defined), so we need to force all elements to be in the base ring during the computation (which might perform a division that goes to the fraction field, but it will eventually brings us back to aBefore, this would fail with a
QQtoGF(3)coercion error:📝 Checklist
⌛ Dependencies