Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/doc/*/tutorial/programming.rst: Update 'standalone script' #37510

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 1, 2024

This tutorial and its translations used to use #!/usr/bin/env sage -python in this example but that was changed to #!/usr/bin/env sage, perhaps to address #8478, except in the Japanese version.
Here we switch that version over and also remove an unnecessary import.

Fixes #8478.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link

github-actions bot commented Apr 1, 2024

Documentation preview for this PR (built with commit 780dbf5; changes) is ready! 🎉

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. But we may have to put standalone Python script examples too later.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 17, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 20, 2024
…one script'

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

This tutorial and its translations used to use `#!/usr/bin/env sage
-python` in this example but that was changed to `#!/usr/bin/env sage`,
perhaps to address sagemath#8478, except in the Japanese version.
Here we switch that version over and also remove an unnecessary import.

Fixes sagemath#8478.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37510
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit ca59b3e into sagemath:develop Apr 27, 2024
14 of 16 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Programming tutorial page seems incorrect
3 participants