src/pyproject.toml: Add 'external' section per draft PEP 725 (unbundled from #37446) #37482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
changed the title
5 tasks
5 tasks
mkoeppe
force-pushed
the
pyproject_external_sagemath_standard
branch
from
1e472cd
to
e5f7ec2
Compare
mkoeppe
force-pushed
the
pyproject_external_sagemath_standard
branch
2 times, most recently
from
3fa06fb
to
c2a9840
Compare
|
Documentation preview for this PR (built with commit ddfd7c0; changes) is ready! 🎉 |
|
This is at this point just a record of external dependencies. LGTM. |
tobiasdiez
added
pending
r: invalid
s: needs review
and removed
s: positive review
labels
|
@roed314 @saraedum @jhpalmieri @VivianePons Someone here is manipulating labels again. |
|
Thanks for the pointer. I'll discuss a response with the committee. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 20, 2024
… 'external' section according to draft PEP 725
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
As done in sagemath#37482 (unbundled from sagemath#37446) for **sagemath-standard**.
- This information will be used in the skeleton generator in
pyodide/pyodide#4438
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37486
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
|
@tobiasdiez has objected to this PR, but cannot comment here. See the here for his reasons. For now, I've set this PR to disputed, and am recording a -1 from Tobias. |
roed314
added
disputed
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 25, 2024
… 'external' section according to draft PEP 725
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
As done in sagemath#37482 (unbundled from sagemath#37446) for **sagemath-standard**.
- This information will be used in the skeleton generator in
pyodide/pyodide#4438
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37486
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
mkoeppe
force-pushed
the
pyproject_external_sagemath_standard
branch
from
c2a9840
to
c99164a
Compare
mkoeppe
changed the title
|
Resolved merge conflict caused by #36982. |
mkoeppe
force-pushed
the
pyproject_external_sagemath_standard
branch
from
c99164a
to
07cbd65
Compare
mkoeppe
force-pushed
the
pyproject_external_sagemath_standard
branch
from
07cbd65
to
505398a
Compare
|
@roed314 @saredum @jipilab The "disputed" should be removed here; there's no review or anything here. |
In my personal opinion, it's @tobiasdiez decision whether to remove the label. As for the missing review, I believe that you blocked him here on GitHub so he cannot go through the normal review process first. Our rules are imo unclear about what is supposed to happen in this case. The rules ask to set to "Needs Work" and leave a comment first. Since that's not an option I guess it's acceptable to skip to "disputed". If that's not how the rules should be interpreted, then maybe an amended version of the rules should be called for a vote on sage-devel to cover this case. |
mkoeppe
force-pushed
the
pyproject_external_sagemath_standard
branch
from
505398a
to
820c753
Compare
mkoeppe
force-pushed
the
pyproject_external_sagemath_standard
branch
from
820c753
to
477d491
Compare
mkoeppe
force-pushed
the
pyproject_external_sagemath_standard
branch
from
477d491
to
ddfd7c0
Compare
|
Let's just go through the "disputed PRs" procedure. The PR has carried the "disputed" label since Apr 20.
|
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 31, 2024
…t PEP 725 (unbundled from sagemath#37446) <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This is aspirational decoration for future use by skeleton generators by distributions such as conda, sage-the-distribution, pyodide. Split out from the disputed sagemath#37446, where it is bundled with a number of other changes, including: creating a `pyproject.toml` file in `SAGE_ROOT`, hardcoding versions of Python packages instead of using the existing `sage_bootstrap` infrastructure, etc. @roed314 @vbraun **The scope of PRs should be chosen to minimize friction, not to maximize friction.** sagemath#36726 (comment) Author: @mkoeppe, based on @tobiasdiez's sagemath#37446. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37482 Reported by: Matthias Köppe Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 2, 2024
…t PEP 725 (unbundled from sagemath#37446) <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This is aspirational decoration for future use by skeleton generators by distributions such as conda, sage-the-distribution, pyodide. Split out from the disputed sagemath#37446, where it is bundled with a number of other changes, including: creating a `pyproject.toml` file in `SAGE_ROOT`, hardcoding versions of Python packages instead of using the existing `sage_bootstrap` infrastructure, etc. @roed314 @vbraun **The scope of PRs should be chosen to minimize friction, not to maximize friction.** sagemath#36726 (comment) Author: @mkoeppe, based on @tobiasdiez's sagemath#37446. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37482 Reported by: Matthias Köppe Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is aspirational decoration for future use by skeleton generators by distributions such as conda, sage-the-distribution, pyodide.
Split out from the disputed #37446, where it is bundled with a number of other changes, including: creating a
pyproject.tomlfile inSAGE_ROOT, hardcoding versions of Python packages instead of using the existingsage_bootstrapinfrastructure, etc. @roed314 @vbraunThe scope of PRs should be chosen to minimize friction, not to maximize friction.
#36726 (comment)
Author: @mkoeppe, based on @tobiasdiez's #37446.
📝 Checklist
⌛ Dependencies