CI: Upload test stats as artifacts, improve output of "List Docker images" #36970
Conversation
mkoeppe
force-pushed
the
ci_upload_stats
branch
from
b8a1a33
to
6e7bcc4
Compare
mkoeppe
changed the title
mkoeppe
force-pushed
the
ci_upload_stats
branch
from
d8082ca
to
ae9b328
Compare
…ainer from buildkit
…ub/workflows/docker.yml
…ocker image is pushed
…Save error status in a file
mkoeppe
force-pushed
the
ci_upload_stats
branch
from
ae9b328
to
78f9f2e
Compare
|
Documentation preview for this PR (built with commit 78f9f2e; changes) is ready! 🎉 |
| # ... and at the beginning of the next build stage, | ||
| # we check the status and exit with an error status. | ||
| CHECK_STATUS_THEN='STATUS=$(cat STATUS 2>/dev/null); case "$STATUS" in ""|0) ;; *) exit $STATUS;; esac; ' | ||
| esac |
There was a problem hiding this comment.
Out of curiosity, how does this trick avoid the problem of "With buildkit we cannot retrieve failed builds."?
How is "failed build" different from "exit" with nonzero status?
There was a problem hiding this comment.
Out of curiosity, how does this trick avoid the problem of "With buildkit we cannot retrieve failed builds."?
By having the next build stage fail at the beginning, instead of failing the current one.
There was a problem hiding this comment.
so that the previous stage remains in the container and the current one discarded...
OK.
|
Otherwise lgtm as far as I can understand. Is this change fully tested (in your fork)? Do you need to test again after 2 months? |
Yes
Well, I've started another run now: https://github.com/mkoeppe/sage/actions/runs/8033793985 |
|
Yes, looking good. e.g. https://github.com/mkoeppe/sage/actions/runs/8033793985/job/21944652261#step:15:61 |
|
OK. Let's see it in the battle field. |
|
Thank you! |
…plex to 7, papilo to 2.2, pyscipopt to 5, onetbb to 2021.11
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
https://www.scipopt.org/doc-9.0.0/html/RN90.php
- [x] scipopt/SCIP-SDP#12
- [ ] scipopt/soplex#35
- [x] needs pyscipopt update
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- Depends on sagemath#37237
- Depends on sagemath#37351
- Depends on sagemath#36970
- Depends on sagemath#37392
URL: sagemath#37494
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
tox -e docker-....now copies logs and stats from the image to the tox environment directoryinfopackage.In a follow-up:
📝 Checklist
⌛ Dependencies