meson 1.2.3, numpy 1.26.1, require meson >= 1.2.0 #36509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
changed the title
|
Documentation preview for this PR (built with commit 2c46325; changes) is ready! 🎉 |
Does that show that it works? This https://github.com/mkoeppe/sage/actions/runs/6622955701/job/18026346564 failed. |
|
Yes, I have reviewed all platforms in this run. |
|
OK. I could check that contourpy 1.1.1 was successfully built in https://github.com/mkoeppe/sage/actions/runs/6622955701/job/18061230398 and meson 1.2.3 was built as well.
Nonetheless, It is unfortunate to see building sage on ubuntu-mantic fail in every target despite of the fix of this PR. Is the timeout by limit of github action? No problem on this platform on sage side? |
We see these timeouts pretty frequently, and they are not specific to a platform: Workflows that normally that 3 hours sometimes get stuck and time out at GH Actions' limit of 6 hours. |
|
I've restarted the failing workflows. https://github.com/mkoeppe/sage/actions/runs/6622955701/job/18110988146 |
I think I saw this phenomenon on my own system.
OK. That's good news. Thanks for explanation. Anyway this PR looks good to me. |
kwankyu
approved these changes
Oct 27, 2023
|
Thank you! |
|
By the way, ubuntu-mantic timed out again. Some suspected lines: from the log. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 28, 2023
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> The increased lower bound for meson is for contourpy, which was updated in sagemath#36320. ubuntu-mantic https://github.com/sagemath/sage/actions/runs/6645713841/j ob/18057705190?pr=36541#step:10:2162 ``` [contourpy-1.1.1] ../meson.build:10:17: ERROR: Meson version is 1.1.1 but project requires >= 1.2.0 ``` <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36509 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
|
On OSX I'm getting |
|
On OS X, this seems to cause (At least that's what |
|
this looks like |
|
Another new doctest failure of the same flavor: |
|
The second one is due to different ordering of roots. |
I also haven't checked that it's due to this PR. |
|
Could be due to numpy version upgrade. |
This definitely is the case. E.g. --- a/src/sage/doctest/parsing.py
+++ b/src/sage/doctest/parsing.py
@@ -1461,7 +1461,7 @@ class SageOutputChecker(doctest.OutputChecker):
...
RuntimeError
sage: 1 # abs tol 2
- -0.5
+ -0.5+0.0001*I
sage: print("0.9999") # rel tol 1e-4
1.0
sage: print("1.00001") # abs tol 1e-5gives Indeed, |
We could sort the roots, say in increasing order of the imaginary part: diff --git a/src/sage/rings/polynomial/polynomial_element.pyx b/src/sage/rings/polynomial/polynomial_element.pyx
index 8e9c4822a7b..edb6d88fb2a 100644
--- a/src/sage/rings/polynomial/polynomial_element.pyx
+++ b/src/sage/rings/polynomial/polynomial_element.pyx
@@ -8104,7 +8104,7 @@ cdef class Polynomial(CommutativePolynomial):
....: x2 = polygen(fld_out)
....: f2 = x2^3 - fld_out(2)
....: for algo in (None, 'pari', 'numpy'):
- ....: rts = f.roots(ring=fld_out, multiplicities=False)
+ ....: rts = sorted(f.roots(ring=fld_out, multiplicities=False), key=lambda root: root.imag())
....: if fld_in == fld_out and algo is None:
....: print("{} {}".format(fld_in, rts))
....: for rt in rts:
@@ -8113,9 +8113,9 @@ cdef class Polynomial(CommutativePolynomial):
Real Field with 53 bits of precision [1.25992104989487]
Real Double Field [1.25992104989...]
Real Field with 100 bits of precision [1.2599210498948731647672106073]
- Complex Field with 53 bits of precision [1.25992104989487, -0.62996052494743... - 1.09112363597172*I, -0.62996052494743... + 1.09112363597172*I]
- Complex Double Field [1.25992104989..., -0.629960524947... - 1.0911236359717...*I, -0.629960524947... + 1.0911236359717...*I]
- Complex Field with 100 bits of precision [1.2599210498948731647672106073, -0.62996052494743658238360530364 - 1.0911236359717214035600726142*I, -0.62996052494743658238360530364 + 1.0911236359717214035600726142*I]
+ Complex Field with 53 bits of precision [-0.62996052494743... - 1.09112363597172*I, 1.25992104989487, -0.62996052494743... + 1.09112363597172*I]
+ Complex Double Field [-0.629960524947... - 1.0911236359717...*I, 1.25992104989..., -0.629960524947... + 1.0911236359717...*I]
+ Complex Field with 100 bits of precision [-0.62996052494743658238360530364 - 1.0911236359717214035600726142*I, 1.2599210498948731647672106073, -0.62996052494743658238360530364 + 1.0911236359717214035600726142*I]
Note that we can find the roots of a polynomial with algebraic
coefficients::That works on my machine. Any better ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The increased lower bound for meson is for contourpy, which was updated in #36320.
ubuntu-mantic https://github.com/sagemath/sage/actions/runs/6645713841/job/18057705190?pr=36541#step:10:2162
📝 Checklist
⌛ Dependencies