-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Remove ci-wsl, ci-cygwin-standard #36357
Conversation
It's OK to remove the Cygwin CI. But |
There is https://github.com/marketplace/actions/setup-wsl which looks up to date and less verbose than our CI |
It's fine if someone would like to fix the WSL one, but is has been broken for a very long time and I don't remember if we ever gained any useful information from it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, fine
Documentation preview for this PR (built with commit aee71fe; changes) is ready! 🎉 |
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> These workflows have been failing for a long time and provide no value. ci-cygwin-standard was already disabled in sagemath/sage - see https://github.com/sagemath/sage/actions/workflows/ci-cygwin- standard.yml The failures of ci-wsl can be seen here: https://github.com/sagemath/sage/actions/workflows/ci-wsl.yml <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36357 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik
These workflows have been failing for a long time and provide no value.
ci-cygwin-standard was already disabled in sagemath/sage - see https://github.com/sagemath/sage/actions/workflows/ci-cygwin-standard.yml
The failures of ci-wsl can be seen here: https://github.com/sagemath/sage/actions/workflows/ci-wsl.yml
📝 Checklist
⌛ Dependencies