Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove ci-wsl, ci-cygwin-standard #36357

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Sep 28, 2023

These workflows have been failing for a long time and provide no value.

ci-cygwin-standard was already disabled in sagemath/sage - see https://github.com/sagemath/sage/actions/workflows/ci-cygwin-standard.yml

The failures of ci-wsl can be seen here: https://github.com/sagemath/sage/actions/workflows/ci-wsl.yml

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@dimpase
Copy link
Member

dimpase commented Sep 28, 2023

It's OK to remove the Cygwin CI. But
IMHO we should investigate and fix the WSL failure. How about just not calling it, with an appropriate comment, rather than removing?

@dimpase
Copy link
Member

dimpase commented Sep 28, 2023

There is https://github.com/marketplace/actions/setup-wsl which looks up to date and less verbose than our CI

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 28, 2023

It's fine if someone would like to fix the WSL one, but is has been broken for a very long time and I don't remember if we ever gained any useful information from it.

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fine

@github-actions
Copy link

Documentation preview for this PR (built with commit aee71fe; changes) is ready! 🎉

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 1, 2023
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
These workflows have been failing for a long time and provide no value.

ci-cygwin-standard was already disabled in sagemath/sage - see
https://github.com/sagemath/sage/actions/workflows/ci-cygwin-
standard.yml

The failures of ci-wsl can be seen here:
https://github.com/sagemath/sage/actions/workflows/ci-wsl.yml

<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36357
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
@vbraun vbraun merged commit b30cc4b into sagemath:develop Oct 8, 2023
16 of 18 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants