Yet more more spkgs confs

[dimpase]

a continuation of #36276 (more system Python packages support via --enable-system-site-packages)

Also, added a Cython 3.0.2 patch to fix the usage of --enable-system-site-packages option. Without it, and sufficiently many Python system packages, sagelib won't build. (Therefore, blocker label added)

[dimpase]

need to add more distros/ stuff

[orlitzky]

We could do cython now too. The standard spkg-configure.m4 works fine. I've only tested it with cython-3.x but we'll probably have that soon from #36110

[mkoeppe]

Can you please redo this branch with proper merge commits for its depencies?

[dimpase]

by right, this branch should be based off develop, but it needs #36276, which is only in the "WIP-develop".
This gives me a headache. Anyhow, it's all in
https://github.com/dimpase/sage/tree/pr36332

[mkoeppe]

I'd suggest to remove the additions to hatch_nodejs_version because #36129 will remove this package.

[dimpase]

I'd suggest to remove the additions to hatch_nodejs_version because #36129 will remove this package.

let's not count chickens before they're hatched. If this gets it before #36129 I'll fix the latter branch, no problem

[mkoeppe]

Or let's not lay eggs that are unwanted?

[dimpase]

one cannot realistically scan all the open PRs and check for potential conflicts

[mkoeppe]

I know, hence my helpful comment

[mkoeppe]

@orlitzky In the platforms tests for --enable-system-site-packages, I see Cython compiler crashes while building sagelib, on many platforms.
https://github.com/mkoeppe/sage/actions/runs/6360039461/job/17277499571#step:12:58476

      Error compiling Cython file:
      ------------------------------------------------------------
      ...
      # distutils: libraries = NTL_LIBRARIES gmp
      ^
      ------------------------------------------------------------
  
      sage/rings/polynomial/polynomial_integer_dense_flint.pyx:1:0: Compiler crash in DebugTransform
  
  
      Compiler crash traceback from this point on:
        File "Cython/Compiler/Visitor.py", line 182, in Cython.Compiler.Visitor.TreeVisitor._visit
        File "/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/Cython/Compiler/ParseTreeTransforms.py", line 4053, in visit_ModuleNode
          self.visit_FuncDefNode(nested_funcdef)
        File "/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/Cython/Compiler/ParseTreeTransforms.py", line 4113, in visit_FuncDefNode
          self.tb.start(arg.name)
        File "/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/Cython/Debugger/DebugWriter.py", line 42, in start
          self.tb.start(name, attrs or {})
        File "src/lxml/saxparser.pxi", line 841, in lxml.etree.TreeBuilder.start
        File "src/lxml/saxparser.pxi", line 769, in lxml.etree.TreeBuilder._handleSaxStart
        File "src/lxml/apihelpers.pxi", line 179, in lxml.etree._makeSubElement
        File "src/lxml/apihelpers.pxi", line 1753, in lxml.etree._tagValidOrRaise
      ValueError: Invalid tag name '.0'
      Traceback (most recent call last):
        File "/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/Cython/Build/Dependencies.py", line 1325, in cythonize_one_helper
          return cythonize_one(*m)
        File "/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/Cython/Build/Dependencies.py", line 1301, in cythonize_one
          raise CompileError(None, pyx_file)
      Cython.Compiler.Errors.CompileError: sage/rings/polynomial/polynomial_integer_dense_flint.pyx

Any thoughts?

[orlitzky]

Any thoughts?

Looks like cython/cython#5552

[orlitzky]

Unrelated: dev-python/stack_data was just renamed to dev-python/stack-data in Gentoo so now its distros/gentoo.txt needs an update.

[dimpase]

calver is for setting up python package versions via date (CalendarVersion)
And, well, the version Sage installs is 2022.6.26
(same version as in Gentoo a.t.m.)

[orlitzky]

calver is for setting up python package versions via date (CalendarVersion) And, well, the version Sage installs is 2022.6.26 (same version as in Gentoo a.t.m.)

But why create a package-version.txt under distros/?

[dimpase]

this happends when you put a bunch of .txt files in a wrong place, then move them to the right place, but...

[dimpase]

Any thoughts?

Looks like cython/cython#5552

I tried patching Cython with the patch they provide, still getting this error.

PS. Sorry, it's OK - I forgot how to patch Gentoo packages, and the patch got lost...

[orlitzky]

PS. Sorry, it's OK - I forgot how to patch Gentoo packages, and the patch got lost...

I opened a Gentoo bug to backport the patch. Otherwise cython-3.0.3 should fix it, or --without-system-cython. I'm happy with this branch if Matthias has no more comments.

[dimpase]

we'd also sort out these endless

Implicit noexcept declaration is deprecated. Function declaration should contain 'noexcept' keyword.

warnings, eventually

[github-actions]

Documentation preview for this PR (built with commit 89a6f9f; changes) is ready! 🎉

[orlitzky]

I don't mind the cython patch but note that it won't help when cython also comes from the system (after this PR). The cython bug you patched is fixed in cython-3.0.3 (#36416), but cython-3.0.3 has a new problem (cython/cython#5748). Hopefully 3.0.4 comes soon.