Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some obsolete "six" dependencies #36206

Merged
merged 3 commits into from
Sep 16, 2023
Merged

Conversation

orlitzky
Copy link
Contributor

@orlitzky orlitzky commented Sep 7, 2023

Cycler, matplotlib, and traitlets no longer need the "six" package. Upstream removal commits are cited in the commit messages.

@fchapoton
Copy link
Contributor

please merge the latest beta and resolve conflicts

@orlitzky
Copy link
Contributor Author

done, thanks

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

Documentation preview for this PR (built with commit 7c8b793; changes) is ready! 🎉

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 14, 2023
    
Cycler, matplotlib, and traitlets no longer need the "six" package.
Upstream removal commits are cited in the commit messages.
    
URL: sagemath#36206
Reported by: Michael Orlitzky
Reviewer(s): Frédéric Chapoton
@vbraun vbraun merged commit 78efe55 into sagemath:develop Sep 16, 2023
16 of 17 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 16, 2023
@orlitzky orlitzky deleted the six-revdeps branch September 22, 2023 00:31
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 23, 2023
…ok 7 upgrade

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
Cherry-picked from sagemath#36129 for easier review
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36206 (merged here)
- Depends on sagemath#36263 (merged here)

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36220
Reported by: Matthias Köppe
Reviewer(s): Michael Orlitzky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants