sage.rings.number_field: Modularization fixes, doctest cosmetics, # needs
#36044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 7, 2023 09:57
kwankyu
reviewed
Aug 8, 2023
kwankyu
reviewed
Aug 8, 2023
| @@ -1880,17 +1887,17 @@ def _convert_non_number_field_element(self, x): | |||
| will convert to the number field, e.g., this one in | |||
| characteristic 7:: | |||
|
|
|||
| sage: f = GF(7)['y']([1,2,3]); f # optional - sage.rings.finite_rings | |||
| sage: f = GF(7)['y']([1,2,3]); f # needs sage.rings.finite_rings | |||
| 3*y^2 + 2*y + 1 | |||
There was a problem hiding this comment.
This is not needed anymore for prime finite fields?
There was a problem hiding this comment.
yes, for small enough prime finite fields
dcoudert
suggested changes
Aug 8, 2023
| @@ -7343,7 +7368,7 @@ def S_unit_group(self, proof=None, S=None): | |||
|
|
|||
| INPUT: | |||
|
|
|||
| - ``proof`` (bool, default True) flag passed to ``pari``. | |||
| - ``proof`` (bool, default True) flag passed to PARI. | |||
There was a problem hiding this comment.
- - ``proof`` (bool, default True) flag passed to PARI.
+ - ``proof`` -- bool (default: ``True``); flag passed to PARI| 81 | ||
| sage: zeta105^3, CC(a)^81 # optional - sage.symbolic | ||
| sage: zeta105^3, CC(a)^81 | ||
| (0.983929588598630 + 0.178556894798637*I, | ||
| 0.983929588598631 + 0.178556894798635*I) | ||
|
|
||
| sage: K.<a> = CyclotomicField(5, embedding=None) |
There was a problem hiding this comment.
shouldn't we add # needs sage.symbolic here ? it's not the same bloc due to blank line
There was a problem hiding this comment.
Above needed sage.symbolic because of exp, pi, i. This one here doesn't
mkoeppe
force-pushed
the
sage_rings_numberfield_modularization
branch
from
76d1d75
to
f9e0342
Compare
|
Thanks both! |
|
Documentation preview for this PR (built with commit f9e0342; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 11, 2023
…ctest cosmetics, `# needs`
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
- Avoiding going through symbolic square roots in `.S_unit_solver`
- `# needs sage.symbolic`, `# needs sage.libs.*`, `# needs
sage.rings.finite_rings` etc.
- Reformatting doctests to fit on the screen
- Codestyle fixes in doctests
- Block tags for `# optional - magma`
- Handle import errors in `NumberField._pushout_`
<!-- Why is this change required? What problem does it solve? -->
This is
- Part of: sagemath#29705
- Cherry-picked from: sagemath#35095
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36044
Reported by: Matthias Köppe
Reviewer(s): David Coudert, Kwankyu Lee, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.S_unit_solver# needs sage.symbolic,# needs sage.libs.*,# needs sage.rings.finite_ringsetc.# optional - magmaNumberField._pushout_This is
📝 Checklist
⌛ Dependencies