Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for exponential and gamma distribution #35939

Merged
merged 10 commits into from
Sep 10, 2023
Merged

Support for exponential and gamma distribution #35939

merged 10 commits into from
Sep 10, 2023

Conversation

teschlg
Copy link
Contributor

@teschlg teschlg commented Jul 12, 2023

I think that the exponential and gamma distributions are essential. Instead of filing an issue I tried to edit the code. Please have a look at the changes.

📚 Description

Support for exponential and gamma distribution from GSL.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Documentation preview for this PR (built with commit acbce52; changes) is ready! 🎉

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. LGTM. The Test and Lint failures are unrelated and fixed elsewhere.

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 2, 2023
    
I think that the exponential and gamma distributions are essential.
Instead of filing an issue I tried to edit the code. Please have a look
at the changes.


### 📚 Description

Support for exponential and gamma distribution from GSL.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#35939
Reported by: Gerald Teschl
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 4, 2023
    
I think that the exponential and gamma distributions are essential.
Instead of filing an issue I tried to edit the code. Please have a look
at the changes.


### 📚 Description

Support for exponential and gamma distribution from GSL.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#35939
Reported by: Gerald Teschl
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 5, 2023
    
I think that the exponential and gamma distributions are essential.
Instead of filing an issue I tried to edit the code. Please have a look
at the changes.


### 📚 Description

Support for exponential and gamma distribution from GSL.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#35939
Reported by: Gerald Teschl
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 10, 2023
    
I think that the exponential and gamma distributions are essential.
Instead of filing an issue I tried to edit the code. Please have a look
at the changes.


### 📚 Description

Support for exponential and gamma distribution from GSL.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#35939
Reported by: Gerald Teschl
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit 3e46882 into sagemath:develop Sep 10, 2023
8 of 11 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants