Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing Sage's python3 spkg produces some untracked files #37887

Closed
2 tasks done
jhpalmieri opened this issue Apr 28, 2024 · 0 comments · Fixed by #38026
Closed
2 tasks done

Installing Sage's python3 spkg produces some untracked files #37887

jhpalmieri opened this issue Apr 28, 2024 · 0 comments · Fixed by #38026
Labels
c: build t: bug
Milestone
sage-10.4

Comments

@jhpalmieri
Copy link
Member

jhpalmieri commented Apr 28, 2024 •
edited
Loading

Steps To Reproduce

Run ./configure --with-system-python3=no; make python3. This is with Sage 10.3.beta4 on OS X.

Expected Behavior

This should succeed, leaving a clean git state.

Actual Behavior

git status returns

On branch develop
Your branch is up to date with 'upstream/develop'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	build/pkgs/python3/spkg-legacy-uninstall.log
	build/pkgs/python3/spkg-legacy-uninstall.time

nothing added to commit but untracked files present (use "git add" to track)

Additional Information

Probably the log files should be in logs/pkgs, maybe called python3-spkg-legacy-uninstall.* in case there could be other spkg-legacy-uninstall scripts that might produce log files.

Environment

- **OS**: OS X 14.4.1
- **Sage Version**: 10.3.beta4

Checklist

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
  • I have read the documentation and troubleshoot guide
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 3, 2024
vbraun pushed a commit to vbraun/sage that referenced this issue May 29, 2024
sagemathgh-38026: Do not create spkg-*.log, spkg-*.time files
dfebbe7 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Clean up after sagemath#37391, which used `sage-logger` for prefixing output;
generating the log/time files was a side effect, which has not proven to
be useful
- Fixes sagemath#37887 @jhpalmieri

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37840 (merged here)
    
URL: sagemath#38026
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this issue May 31, 2024
sagemathgh-38026: Do not create spkg-*.log, spkg-*.time files
efc613a 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Clean up after sagemath#37391, which used `sage-logger` for prefixing output;
generating the log/time files was a side effect, which has not proven to
be useful
- Fixes sagemath#37887 @jhpalmieri

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37840 (merged here)
    
URL: sagemath#38026
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build t: bug
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging a pull request may close this issue.

Do not create spkg-*.log, spkg-*.time files mkoeppe/sage
2 participants
@jhpalmieri @mkoeppe