-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random doctest failure in structure/coerce_actions.pyx #35973
Comments
If others can confirm the failure, this is an instance of #32544. |
5 tasks
mkoeppe
added a commit
to mkoeppe/sage
that referenced
this issue
Dec 21, 2023
mkoeppe
added a commit
to mkoeppe/sage
that referenced
this issue
Dec 26, 2023
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jan 2, 2024
…s.pyx A doctest in coerce_actions.pyx tests whether "large multiplications can be interrupted". Depending on the random input and on the speed of the machine, that multiplication can happen too fast, and then the interrupt doesn't happen in time. So let's make the multiplication take longer. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> This should fix sagemath#35973. In some testing: this multiplication uses `P = E.random_element()` where `E` is some elliptic curve. If this happens to be `(0:1:0)`, then on at least one machine, the multiplication is completed too quickly. We could reject that particular point, or we can increase the multiplication by a factor of 10. This PR uses the second approach. <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [X] The title is concise, informative, and self-explanatory. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36789 Reported by: John H. Palmieri Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jan 5, 2024
…s.pyx A doctest in coerce_actions.pyx tests whether "large multiplications can be interrupted". Depending on the random input and on the speed of the machine, that multiplication can happen too fast, and then the interrupt doesn't happen in time. So let's make the multiplication take longer. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> This should fix sagemath#35973. In some testing: this multiplication uses `P = E.random_element()` where `E` is some elliptic curve. If this happens to be `(0:1:0)`, then on at least one machine, the multiplication is completed too quickly. We could reject that particular point, or we can increase the multiplication by a factor of 10. This PR uses the second approach. <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [X] The title is concise, informative, and self-explanatory. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36789 Reported by: John H. Palmieri Reviewer(s):
mkoeppe
added a commit
to mkoeppe/sage
that referenced
this issue
Jan 14, 2024
mkoeppe
added a commit
to mkoeppe/sage
that referenced
this issue
Jan 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps To Reproduce
OS X 13.4.1 on Apple M1.
./sage -t --long src/sage/structure/coerce_actions.pyx
typically passes, but with a specific random seed, I get failures:fails as described below.
Expected Behavior
Doctests should pass.
Actual Behavior
fails:
Additional Information
No response
Environment
Checklist
The text was updated successfully, but these errors were encountered: