Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean the use of weights in spanning_tree.pyx #32805

Closed
dcoudert opened this issue Oct 30, 2021 · 21 comments
Closed

Clean the use of weights in spanning_tree.pyx #32805

dcoudert opened this issue Oct 30, 2021 · 21 comments
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-9.5

Comments

@dcoudert
Copy link
Contributor

part of #13112 and follow-up of #32723.

We add parameters by_weight, weight_function and check_weight to several methods and deprecate former parameters like wfunction and weighted.

Method random_spanning_tree is taken care of in #30566.

Component: graph theory

Author: David Coudert

Branch/Commit: 776b31b

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/32805
@dcoudert dcoudert added this to the sage-9.5 milestone Oct 30, 2021
@dcoudert
Copy link
Contributor Author

New commits:

28eec1etrac #32805: unify use of weights
ed7a24btrac #32805: small change

@dcoudert
Copy link
Contributor Author

Author: David Coudert

@dcoudert

This comment has been minimized.

Sign in to view
@dcoudert
Copy link
Contributor Author

Commit: ed7a24b

@dcoudert
Copy link
Contributor Author

Branch: public/graphs/32805

@dcoudert
Copy link
Contributor Author

comment:2

possible conflict with #32798 in min_spanning_tree.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 11, 2021

Changed commit from ed7a24b to 8e192f7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 11, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

8e192f7trac #32805: revert some changes

@dcoudert
Copy link
Contributor Author

comment:4

I have revert some changes from this ticket since these changes are done in #32798. Now the 2 tickets are not intersecting.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 11, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

24c55aatrac #32805: revert some another change

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 11, 2021

Changed commit from 8e192f7 to 24c55aa

@dcoudert
Copy link
Contributor Author

comment:6

algorithm Filter_Kruskal works on simple graphs.

@dcoudert

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor

comment:8

maybe the deprecation should be doctested, non ?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 4, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

e8fa261trac #32805: merged with 9.5.beta7
776b31btrac #32805: doctest rename warnings

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 4, 2021

Changed commit from 24c55aa to 776b31b

@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 4, 2021

comment:10

You are right. Done.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:11

merci, je passe en positif

@dcoudert
Copy link
Contributor Author

dcoudert commented Dec 4, 2021

comment:12

Merci à toi.

@vbraun
Copy link
Member

vbraun commented Dec 19, 2021

Changed branch from public/graphs/32805 to 776b31b

@vbraun vbraun closed this as completed in cc6ce3d Dec 19, 2021
@dkrenn dkrenn mentioned this issue Jan 29, 2023
Open
@dcoudert dcoudert mentioned this issue Aug 11, 2023
Merged
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this issue Aug 12, 2023
sagemathgh-36075: Remove rename warning in spanning_tree.pyx
a00ac4f 
    
We remove the rename warning introduced in sagemath#32805 to clean the use of
weights in `spanning_tree.pyx`.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36075
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @dcoudert