Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.matrix.args: Remove compile-time dependency on cypari2 #32455

Closed
mkoeppe opened this issue Sep 2, 2021 · 15 comments
Closed

sage.matrix.args: Remove compile-time dependency on cypari2 #32455

mkoeppe opened this issue Sep 2, 2021 · 15 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 2, 2021

Follow-up on #30022

Depends on #32441

CC: @kliem @videlec @tscrim

Component: refactoring

Author: Jonathan Kliem

Branch/Commit: 13f9003

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32455

@mkoeppe mkoeppe added this to the sage-9.5 milestone Sep 2, 2021
@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

Author: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

Dependencies: #32441

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

Commit: b24bc40

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

Branch: public/32455

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

New commits:

2924e24convert_sage from #32441 to avoid merge conflicts
b24bc40move pari type detection to convert_sage

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

Changed commit from b24bc40 to 34fde45

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

New commits:

08084b3sage.libs.pari.convert_sage: Move set_integer_from_gen here from sage.rings.integer (set_from_pari_gen)
9986723remove compile time dependency of Integer and Rational on cypari2
c08a8b5remove compile-time dependency on flint from integer
88d91bause try ... except ... else
b4477dafixed indent
6ae2006Merge branch 'develop' of git://trac.sagemath.org/sage into public/32441-reb
1aa8cd1pull in from #30022 to avoid merge conflict
05bb421remove pari compile time dependency from rings.fast_arith
34fde45move pari type detection to convert_sage

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

Changed branch from public/32455 to public/32455-reb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 3, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0087de5fix function signatures
86e138emove pari type detection to convert_sage

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 3, 2021

Changed commit from 34fde45 to 86e138e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2021

Changed commit from 86e138e to 13f9003

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

cbbef63pull in from #30022 to avoid merge conflict
2c46a20remove pari compile time dependency from rings.fast_arith
41df930fix function signatures
13f9003move pari type detection to convert_sage

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 19, 2021

Reviewer: Matthias Koeppe

@kliem
Copy link
Contributor

kliem commented Sep 20, 2021

comment:6

Thank you.

@vbraun
Copy link
Member

vbraun commented Sep 25, 2021

Changed branch from public/32455-reb to 13f9003

@vbraun vbraun closed this as completed in 3d9981f Sep 25, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants