Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.rings.fast_arith: Remove compile-time dependency on cypari2 #32441

Closed
mkoeppe opened this issue Aug 31, 2021 · 33 comments
Closed

sage.rings.fast_arith: Remove compile-time dependency on cypari2 #32441

mkoeppe opened this issue Aug 31, 2021 · 33 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 31, 2021

Follow-up on #30022

CC: @kliem @videlec @tscrim

Component: refactoring

Author: Jonathan Kliem

Branch/Commit: 41df930

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32441

@mkoeppe mkoeppe added this to the sage-9.5 milestone Aug 31, 2021
@kliem
Copy link
Contributor

kliem commented Sep 1, 2021

Author: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Sep 1, 2021

Dependencies: 30022

@kliem
Copy link
Contributor

kliem commented Sep 1, 2021

Commit: e0c8466

@kliem
Copy link
Contributor

kliem commented Sep 1, 2021

New commits:

a8a9437pull in from #30022 to avoid merge conflict
e0c8466remove pari compile time dependency from rings.fast_arith

@kliem
Copy link
Contributor

kliem commented Sep 1, 2021

Branch: public/32441

@kliem
Copy link
Contributor

kliem commented Sep 1, 2021

Changed dependencies from 30022 to #30022

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2021

Changed commit from e0c8466 to cbfec03

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

cbfec03fix function signatures

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

cfcf047add doctests that confirms that cysignals interfaces the PARI signals
d422435updated checksums

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2021

Changed commit from cbfec03 to d422435

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 2, 2021

comment:5

wrong ticket?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2021

Changed commit from d422435 to cbfec03

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

@kliem
Copy link
Contributor

kliem commented Sep 2, 2021

comment:7

Replying to @mkoeppe:

wrong ticket?

Thanks. I was confused why the checksum for #32431 were incorrect. That explains it.

I thought I had done #32441 from a different computer, but I guess I was in remote shell. Didn't catch on at that time.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 3, 2021

comment:8

Also I think commit a8a9437 needs to be dropped

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

comment:10

Replying to @mkoeppe:

Also I think commit a8a9437 needs to be dropped

This was on purpose. I accidently already commit fast_arith.pyx. But this is mostly to avoid merge conflicts in convert_sage.pyx, because both tickets append to that file. This will not work.

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

comment:11

Hence the dependency on #30022.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 3, 2021

comment:13

I don't get it; can you not just rebase onto the branch of #30022, i.e., b4477da?

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

Changed branch from public/32441 to public/32441-reb

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

New commits:

08084b3sage.libs.pari.convert_sage: Move set_integer_from_gen here from sage.rings.integer (set_from_pari_gen)
9986723remove compile time dependency of Integer and Rational on cypari2
c08a8b5remove compile-time dependency on flint from integer
88d91bause try ... except ... else
b4477dafixed indent
6ae2006Merge branch 'develop' of git://trac.sagemath.org/sage into public/32441-reb
1aa8cd1pull in from #30022 to avoid merge conflict
05bb421remove pari compile time dependency from rings.fast_arith

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

Changed commit from cbfec03 to 05bb421

@kliem
Copy link
Contributor

kliem commented Sep 3, 2021

comment:15

Replying to @mkoeppe:

I don't get it; can you not just rebase onto the branch of #30022, i.e., b4477da?

Indeed, it doesn't work. I tried to pull in only those files, but git couldn't even get it to work and I still had merge conflicts.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 3, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

0087de5fix function signatures

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 3, 2021

Changed commit from 05bb421 to 0087de5

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 13, 2021

comment:17

9.5.beta1 is out... rebase?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

1c11285Merge branch 'public/32441-reb' of git://trac.sagemath.org/sage into public/32441-reb2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2021

Changed commit from 0087de5 to 1c11285

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

cbbef63pull in from #30022 to avoid merge conflict
2c46a20remove pari compile time dependency from rings.fast_arith
41df930fix function signatures

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2021

Changed commit from 1c11285 to 41df930

@kliem
Copy link
Contributor

kliem commented Sep 14, 2021

Changed dependencies from #30022 to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 19, 2021

Reviewer: Matthias Koeppe

@kliem
Copy link
Contributor

kliem commented Sep 20, 2021

comment:22

Thank you.

@vbraun
Copy link
Member

vbraun commented Sep 25, 2021

Changed branch from public/32441-reb to 41df930

@vbraun vbraun closed this as completed in ac845b3 Sep 25, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants