Skip to content

Commit

Permalink
Trac #32598: cvxopt selftest should rely on pytest, not nose
Browse files Browse the repository at this point in the history
Currently, selftest of `cvxopt` rely on `nose`, which is broken
(see#32595). Upstream does not mention `nose` anymore and recommends to
use `pytest`, see https://cvxopt.org/install/index.html

URL: https://trac.sagemath.org/32598
Reported by: tmonteil
Ticket author(s): Thierry Monteil
Reviewer(s): Matthias Koeppe
  • Loading branch information
Release Manager committed Oct 12, 2021
2 parents 993c578 + 2586c1e commit 25abdd9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion build/pkgs/cvxopt/dependencies
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$(PYTHON) numpy $(BLAS) gsl glpk suitesparse | $(PYTHON_TOOLCHAIN) pkgconfig nose matplotlib
$(PYTHON) numpy $(BLAS) gsl glpk suitesparse | $(PYTHON_TOOLCHAIN) pkgconfig matplotlib $(and $(filter-out no,$(SAGE_CHECK_cvxopt)), pytest)

matplotlib is needed to test cvxopt (i.e., if SAGE_CHECK=yes). See #12742.

Expand Down
7 changes: 1 addition & 6 deletions build/pkgs/cvxopt/spkg-check.in
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
cd src

if ! command -v nosetests ; then
echo >&2 'Testing cvxopt requires the package nose to be installed'
exit 1
fi

nosetests
pytest

0 comments on commit 25abdd9

Please sign in to comment.