Skip to content

Commit

Permalink
Trac #32597: networkx selftests are broken, use pytest instead of nose
Browse files Browse the repository at this point in the history
In Sage, `networkx` selftests which are run by `nose` are broken
(perhaps just because of #32595). Upstream now relies on `pytest` for
its selftests, see
https://github.com/networkx/networkx/blob/main/INSTALL.rst

URL: https://trac.sagemath.org/32597
Reported by: tmonteil
Ticket author(s): Thierry Monteil
Reviewer(s): Matthias Koeppe
  • Loading branch information
Release Manager committed Oct 12, 2021
2 parents db48512 + 67ceb09 commit 993c578
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion build/pkgs/networkx/dependencies
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$(PYTHON) decorator | $(PYTHON_TOOLCHAIN) scipy $(and $(filter-out no,$(SAGE_CHECK_networkx)), nose pytest)
$(PYTHON) decorator | $(PYTHON_TOOLCHAIN) scipy $(and $(filter-out no,$(SAGE_CHECK_networkx)), pytest)

----------
All lines of this file are ignored except the first.
Expand Down
7 changes: 1 addition & 6 deletions build/pkgs/networkx/spkg-check.in
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
cd src

if ! command -v nosetests ; then
echo >&2 'Testing networkx requires the package nose to be installed'
exit 1
fi

nosetests networkx -v
pytest

0 comments on commit 993c578

Please sign in to comment.