Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.4.1-1 #799

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Bump version to 1.4.1-1 #799

merged 2 commits into from
Jul 23, 2024

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jul 23, 2024

Bump version for the new release. Release notes:

What's Changed

@mmv08 mmv08 requested review from a team, nlordell, akshay-ap and remedcu and removed request for a team July 23, 2024 08:29
@coveralls
Copy link

coveralls commented Jul 23, 2024

Pull Request Test Coverage Report for Build 10056986884

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 94.2%

Files with Coverage Reduction New Missed Lines %
contracts/SafeL2.sol 7 0.0%
Totals Coverage Status
Change from base Build 10055275611: 0.0%
Covered Lines: 315
Relevant Lines: 330

💛 - Coveralls

@@ -1,6 +1,6 @@
{
"name": "@safe-global/safe-contracts",
"version": "1.4.1-build.0",
"version": "1.4.1-1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you bump the version in the README as well? I think it still points to -build.0.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: As @mmv08 - referencing a commit hash is self-referencial and not really possible. The workaround is to reference a tag by name instead.

@mmv08 mmv08 force-pushed the bump-version/v1.4.1-1 branch from 4837ac2 to 0d175a3 Compare July 23, 2024 10:00
README.md Show resolved Hide resolved
@mmv08 mmv08 force-pushed the bump-version/v1.4.1-1 branch from 6ebf749 to 87ddf85 Compare July 23, 2024 10:10
@mmv08 mmv08 merged commit a1f6da9 into release/v1.4.1 Jul 23, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
@mmv08 mmv08 deleted the bump-version/v1.4.1-1 branch July 23, 2024 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants