Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.4.1: Singleton factory update #798

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jul 23, 2024

V1.4.1 Currently uses the outdated version of the safe-singleton factory, which confuses developers when it comes to deploying contracts as it requires them to do a few manual steps before deploying. This PR updates the readme and the package used, when merged we can prepare a new release with the updated factory

@mmv08 mmv08 requested review from a team, nlordell, akshay-ap and remedcu and removed request for a team July 23, 2024 08:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10055020204

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.2%

Totals Coverage Status
Change from base Build 10054960862: 0.0%
Covered Lines: 315
Relevant Lines: 330

💛 - Coveralls

@mmv08 mmv08 merged commit 0a4e94f into release/v1.4.1 Jul 23, 2024
10 of 11 checks passed
@mmv08 mmv08 deleted the v1.4.1/singleton-factory-update branch July 23, 2024 08:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants