Closes #233: Add setup event #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmeissner
force-pushed
the
feature/issue_233_more_events
branch
from
b7c34a4
to
7c1e791
Compare
Uxio0
reviewed
Mar 22, 2021
Uxio0
requested changes
Mar 23, 2021
| address[] owners, | ||
| uint256 threshold, | ||
| address initializer, | ||
| address fallbackHandler |
There was a problem hiding this comment.
address paymentToken, uint256 payment, address payable paymentReceiver should be there until we remove them
There was a problem hiding this comment.
I left them out as they do not have an impact on the internal state of the safe. And as they cost gas I would only include critical information.
Uxio0
approved these changes
Mar 23, 2021
Closed
1 task
Saw-mon-and-Natalie
pushed a commit
to Saw-mon-and-Natalie/safe-contracts
that referenced
this pull request
Nov 1, 2023
fdarian
pushed a commit
to fdarian/safe-contracts
that referenced
this pull request
Jan 14, 2024
Check if a transaction is valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #233