Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add events for initial configuration #233

Closed
rmeissner opened this issue Nov 9, 2020 · 2 comments · Fixed by #279
Closed

Add events for initial configuration #233

rmeissner opened this issue Nov 9, 2020 · 2 comments · Fixed by #279
Labels
enhancement
Milestone
contracts-safe-1.3.0

Comments

@rmeissner
Copy link
Member

rmeissner commented Nov 9, 2020 •
edited
Loading

To be able to properly track the internal state of the Safe we should emit an event for the initial configuration
@rmeissner rmeissner added enhancement future Features for next major contract version labels Nov 9, 2020
@Uxio0
Copy link
Member

Uxio0 commented Nov 9, 2020

Ideas:

  • ExecutionSuccess could have the nonce of the executed transaction. This would be very useful
  • Emit event of AddedOwner and ChangedThreshold when Safe is created

@rmeissner
Copy link
Member Author

Ideas:

  • Add more information to exection events: e.g. first 4 bytes, data hash, value, to

@rmeissner rmeissner added this to the contracts-safe-1.3.0 milestone Jan 18, 2021
@rmeissner rmeissner changed the title Improve indexability of the Safe Add events for initial Configuration Mar 19, 2021
@rmeissner rmeissner changed the title Add events for initial Configuration Add events for initial configuration Mar 19, 2021
@rmeissner rmeissner removed the future Features for next major contract version label Mar 19, 2021
@rmeissner rmeissner mentioned this issue Mar 19, 2021
Merged
fdarian pushed a commit to fdarian/safe-contracts that referenced this issue Jan 14, 2024
@germartinez
Merge pull request safe-global#233 from safe-global/signtx-immutable
7c27fa4 
Make signTransaction method immutable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
contracts-safe-1.3.0
Development

Successfully merging a pull request may close this issue.

Closes #233: Add setup event safe-global/safe-smart-account
2 participants
@rmeissner @Uxio0