Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 4337 module v0.3.0-1 #445

Merged

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jun 19, 2024

This PR:

> hardhat deploy-contracts --network "mainnet"

Nothing to compile
No need to generate any newer typings.
reusing "SafeModuleSetup" at 0x2dd68b007B46fBe91B9A7c3EDa5A7a1063cB5b47
reusing "Safe4337Module" at 0x75cf11467937ce3F2f357CE24ffc3DBF8fD5c226

@mmv08 mmv08 requested a review from a team as a code owner June 19, 2024 07:37
@mmv08 mmv08 requested review from nlordell, akshay-ap and remedcu and removed request for a team June 19, 2024 07:37
@mmv08 mmv08 force-pushed the 426-release-a-new-4337-module-version-with-updated-js-tooling branch from 8043475 to 431704c Compare June 19, 2024 07:41
@akshay-ap
Copy link
Member

My understanding is that as the script has a bug fix, new version would be v0.3.1. Curious to know why there is v0.3.0-1 as new version instead? I couldn't find it as a convention in npm docs.

Copy link
Member

@akshay-ap akshay-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comment.

@mmv08
Copy link
Member Author

mmv08 commented Jun 19, 2024

My understanding is that as the script has a bug fix, new version would be v0.3.1. Curious to know why there is v0.3.0-1 as new version instead? I couldn't find it as a convention in npm docs.

There is no bug in the script or the contracts per se. The bug is in the surrounding tooling. We had problems with NPM where it would generate a platform-specific lockfile and refuse to regenerate it on other platforms. This led the v0.3.0 to be only usable to deploy or verify contracts on the platform where the lockfile was generated, which happens to be Linux.

The version number suggestion came from Nick here

@mmv08 mmv08 merged commit 75e56fd into main Jun 19, 2024
17 checks passed
@mmv08 mmv08 deleted the 426-release-a-new-4337-module-version-with-updated-js-tooling branch June 19, 2024 08:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants