Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a new 4337 module version with updated JS tooling. #426

Closed
mmv08 opened this issue May 28, 2024 · 1 comment
Closed

Release a new 4337 module version with updated JS tooling. #426

mmv08 opened this issue May 28, 2024 · 1 comment
Assignees

Comments

@mmv08
Copy link
Member

mmv08 commented May 28, 2024

Context / issue

I needed to deploy & verify the 4337 contract to a new network, so I checked out to [4337/v0.3.0](https://github.com/safe-global/safe-modules/tree/4337/v0.3.0) tag.

And ran into an issue with installing dependencies:

~/projects/safe/safe-modules #4337/v0.3.0@5931a275 ❯ npm i                                                                                                                                               22s 17:22:01
npm error code 1
npm error path /Users/mmv/projects/safe/safe-modules/modules/4337
npm error command failed
npm error command sh -c npm run build
npm error > @safe-global/[email protected] build
npm error > npm run build:sol && npm run build:ts
npm error
npm error
npm error > @safe-global/[email protected] build:sol
npm error > rimraf build typechain-types && hardhat compile
npm error Error HH18: You installed Hardhat with a corrupted lockfile due to the NPM bug #4828.
npm error
npm error Please delete your node_modules, package-lock.json, reinstall your project, and try again.
npm error For more info go to https://hardhat.org/HH18 or run Hardhat with --show-stack-traces
npm error npm error Lifecycle script `build:sol` failed with error:
npm error npm error Error: command failed
npm error npm error   in workspace: @safe-global/[email protected]
npm error npm error   at location: /Users/mmv/projects/safe/safe-modules/modules/4337
npm error npm error Lifecycle script `build` failed with error:
npm error npm error Error: command failed
npm error npm error   in workspace: @safe-global/[email protected]
npm error npm error   at location: /Users/mmv/projects/safe/safe-modules/modules/4337

npm error A complete log of this run can be found in: /Users/mmv/.npm/_logs/2024-05-27T15_22_27_743Z-debug-0.log

In the end, I had to use the current main branch, which contains pnpm updates (luckily, we didn't do any code changes to the 4337 contract)

Proposed solution

Release a new version with updated js tooling and a new tag (e.g., 4337/v0.3.0-1 per @nlordell suggestion)

@mmv08 mmv08 self-assigned this Jun 18, 2024
mmv08 added a commit that referenced this issue Jun 19, 2024
This PR:
- Implements #426 by
releasing the code we have now under a new tag
- There were no contract changes, so the expected addresses are the
same. I confirmed it by trying to deploy to a network where the
contracts are already deployed:
```
> hardhat deploy-contracts --network "mainnet"

Nothing to compile
No need to generate any newer typings.
reusing "SafeModuleSetup" at 0x2dd68b007B46fBe91B9A7c3EDa5A7a1063cB5b47
reusing "Safe4337Module" at 0x75cf11467937ce3F2f357CE24ffc3DBF8fD5c226
```
@mmv08
Copy link
Member Author

mmv08 commented Jun 19, 2024

@mmv08 mmv08 closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant