Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #58: Promisified API #63

Merged
merged 86 commits into from
Nov 24, 2020
Merged
Changes from 1 commit
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
612f496
wip
mmv08 Oct 29, 2020
9840f97
move sendTransaction to TXs class
mmv08 Oct 29, 2020
a80b53a
dep bump
mmv08 Nov 2, 2020
379406e
promise based communicator wip
mmv08 Nov 2, 2020
2b3ea14
promise based communicator wip
mmv08 Nov 2, 2020
dc63153
types wip
mmv08 Nov 3, 2020
d7ae8f6
types wip
mmv08 Nov 3, 2020
613d083
first promisified method test - sendInitializationMessage
mmv08 Nov 3, 2020
33d77f4
build fix
mmv08 Nov 5, 2020
30b2563
update package.json
mmv08 Nov 6, 2020
901b0ee
use arrow functions to not deal with function binding
mmv08 Nov 6, 2020
8e89ef8
dep bump
mmv08 Nov 6, 2020
4a0fb0f
messageId -> method in send func
mmv08 Nov 6, 2020
be32962
incoming msg handler wip
mmv08 Nov 6, 2020
ca88eac
update incoming message handler
mmv08 Nov 6, 2020
06a4722
add known origins
mmv08 Nov 6, 2020
8458c6b
first promisified method was successfully called 🎉
mmv08 Nov 6, 2020
a0ea72d
sdk wip
mmv08 Nov 9, 2020
19731d2
fix build
mmv08 Nov 9, 2020
fbd3e62
communicator wip
mmv08 Nov 9, 2020
0c3b16f
fix handling incomming messages
mmv08 Nov 9, 2020
154588e
dep bump
mmv08 Nov 10, 2020
4db16c5
include sdk version, check method validity
mmv08 Nov 10, 2020
3a1982b
use fs.readfilesync instead of require
mmv08 Nov 10, 2020
2e621d4
bring back require and tweak pkg json
mmv08 Nov 10, 2020
87dbee5
add version check
mmv08 Nov 10, 2020
e125e67
Fix version export
mmv08 Nov 10, 2020
53454c2
fix version number
mmv08 Nov 10, 2020
3c1398c
fix version number & comparing function
mmv08 Nov 10, 2020
8e5c151
Fix semver check
mmv08 Nov 10, 2020
78c0f46
throw error in txs.send if tx was rejectted
mmv08 Nov 10, 2020
3921f52
add types
mmv08 Nov 11, 2020
bbcd844
extend types
mmv08 Nov 11, 2020
3238e96
more type improvements
mmv08 Nov 11, 2020
b4d3299
more type improvements
mmv08 Nov 11, 2020
dc27b58
more type improvements
mmv08 Nov 11, 2020
53fdfa2
update types for getStorageAt call
mmv08 Nov 12, 2020
f5ed2cf
fix getStorageAt test
mmv08 Nov 12, 2020
5e910b0
add numberToHex formatter
mmv08 Nov 12, 2020
b4cd34d
format number to hex in getBlockByNumber
mmv08 Nov 12, 2020
f17cc11
[breaks things]: add types to rpc calls
mmv08 Nov 12, 2020
295f762
types wip
mmv08 Nov 13, 2020
fde32ac
types fix
mmv08 Nov 16, 2020
6ad9b45
Fix tests compilation
mmv08 Nov 16, 2020
1177986
Fix types
mmv08 Nov 16, 2020
80dd993
Type updateS
mmv08 Nov 16, 2020
9aeb41e
types fix
mmv08 Nov 16, 2020
b12cf01
types fix
mmv08 Nov 16, 2020
969efcc
remove eslint comment
mmv08 Nov 16, 2020
ed8d0a2
fix send txs return type
mmv08 Nov 16, 2020
83e30a9
fix tests for transactions
mmv08 Nov 16, 2020
c5b5110
formatting
mmv08 Nov 16, 2020
55df940
remove interfaces deployed by gnosis from constructor
mmv08 Nov 17, 2020
160879c
add log
mmv08 Nov 17, 2020
f4c1cbb
import fix
mmv08 Nov 17, 2020
0e6bdc0
update message validation to check parent element
mmv08 Nov 17, 2020
c27c575
Check for window existance in communicator's send
mmv08 Nov 17, 2020
77043e7
types fix
mmv08 Nov 17, 2020
08d47ba
Fix rpc response
mmv08 Nov 17, 2020
7506f8b
add bootstrap function
mmv08 Nov 17, 2020
ac60622
remove log
mmv08 Nov 17, 2020
e7c85ed
add a test that checks getEnvInfo is called on init
mmv08 Nov 17, 2020
2e98395
add functions for generating requests/responses
mmv08 Nov 18, 2020
4119efa
import fix
mmv08 Nov 18, 2020
f3da4dc
import fix
mmv08 Nov 18, 2020
135a38b
add export
mmv08 Nov 18, 2020
3936afd
Add export for formatter
mmv08 Nov 18, 2020
cab5e96
fix make error response
mmv08 Nov 18, 2020
fdbd86f
dep bump
mmv08 Nov 19, 2020
491f5df
Add version to error response
mmv08 Nov 19, 2020
54ca2a4
resolve whole data object, not only response key
mmv08 Nov 19, 2020
1f371c5
Update types
mmv08 Nov 19, 2020
3e32a4d
fix txs.send method
mmv08 Nov 19, 2020
8cf9681
fix types & hex formatter
mmv08 Nov 19, 2020
2d9b62f
Remove origin check
rmeissner Nov 21, 2020
b1a2b7d
remove unused var
mmv08 Nov 24, 2020
d810979
Merge branch 'feature/58-promisified-api-2' of github.com:gnosis/safe…
mmv08 Nov 24, 2020
72ca8d5
readme change to run github actions
mmv08 Nov 24, 2020
93358b1
readme change to run github actions 2
mmv08 Nov 24, 2020
bbd466b
shorten import
mmv08 Nov 24, 2020
7e6b2aa
accept opts object
mmv08 Nov 24, 2020
3244e2b
update rpc arguments
mmv08 Nov 24, 2020
1fef70d
add docs for rpc calls
mmv08 Nov 24, 2020
e881992
fix valid origin check
mmv08 Nov 24, 2020
bd8868b
rename formatter
mmv08 Nov 24, 2020
12ed65a
remove ethBalance from SafeInfo
mmv08 Nov 24, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
import fix
  • Loading branch information
mmv08 committed Nov 18, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit f3da4dcca3763a49301ba5f51f625c6a505730f5
9 changes: 4 additions & 5 deletions src/communication/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import semver from 'semver';
import { InterfaceMessageEvent, Communicator, Methods, SDKRequestData } from '../types';
import { InterfaceMessageEvent, Communicator, Methods } from '../types';
import { MessageFormatter } from './messageFormatter';
import { generateRequestId } from './utils';

// eslint-disable-next-line
type Callback = (response: any) => void;
@@ -41,13 +40,13 @@ class PostMessageCommunicator implements Communicator {
};

private handleIncomingMessage = (payload: InterfaceMessageEvent['data']): void => {
const { requestId } = payload;
const { id } = payload;

const cb = this.callbacks.get(requestId);
const cb = this.callbacks.get(id);
if (cb) {
cb(payload.response);

this.callbacks.delete(requestId);
this.callbacks.delete(id);
}
};