Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #58: Promisified API #63

Merged
merged 86 commits into from
Nov 24, 2020
Merged

Feature #58: Promisified API #63

merged 86 commits into from
Nov 24, 2020

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Nov 24, 2020 •
edited
Loading

This PR:

  • Implements a new version of safe apps SDK with promise-based API and also refactors the internals

Now the communicator (a module responsible for communicating with the interface) will wait for a response from the interface side. It acts like a regular HTTP Server now. No more request ids.

The message also includes version info now, so we differ requests from SDK v1/v2

mmv08 added 30 commits October 29, 2020 16:30
@mmv08
wip
612f496
@mmv08
move sendTransaction to TXs class
9840f97
@mmv08
dep bump
a80b53a
@mmv08
promise based communicator wip
379406e
@mmv08
promise based communicator wip
2b3ea14
@mmv08
types wip
dc63153
@mmv08
types wip
d7ae8f6
@mmv08
first promisified method test - sendInitializationMessage
613d083
@mmv08
build fix
33d77f4
@mmv08
update package.json
30b2563
@mmv08
use arrow functions to not deal with function binding
901b0ee
@mmv08
dep bump
8e89ef8
@mmv08
messageId -> method in send func
4a0fb0f
@mmv08
incoming msg handler wip
be32962
@mmv08
update incoming message handler
ca88eac
@mmv08
add known origins
06a4722
@mmv08
first promisified method was successfully called 🎉
8458c6b
@mmv08
sdk wip
a0ea72d
@mmv08
fix build
19731d2
@mmv08
communicator wip
fbd3e62
@mmv08
fix handling incomming messages
0c3b16f
@mmv08
dep bump
154588e
@mmv08
include sdk version, check method validity
4db16c5
@mmv08
use fs.readfilesync instead of require
3a1982b
@mmv08
bring back require and tweak pkg json
2e621d4
@mmv08
add version check
87dbee5
@mmv08
Fix version export
e125e67
@mmv08
fix version number
53454c2
@mmv08
fix version number & comparing function
3c1398c
@mmv08
Fix semver check
8e5c151
rmeissner
rmeissner reviewed Nov 24, 2020
View reviewed changes
src/eth/index.ts Outdated Show resolved Hide resolved
rmeissner
rmeissner approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@rmeissner rmeissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will try to test it in action later this week ;)

rmeissner
rmeissner reviewed Nov 24, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mmv08 mmv08 merged commit b4e5a7f into development Nov 24, 2020
@mmv08 mmv08 deleted the feature/58-promisified-api-2 branch November 24, 2020 15:59
mmv08 added a commit that referenced this pull request May 13, 2021
@mmv08
Merge pull request #63 from gnosis/feature/58-promisified-api-2
37c03bb 
Feature #58: Promisified API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosampler nicosampler nicosampler left review comments

@rmeissner rmeissner rmeissner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmv08 @rmeissner @nicosampler