Add providedBy manifest info to readme #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
rmeissner
requested changes
Sep 15, 2020
README.md
Outdated
| @@ -127,7 +127,8 @@ It is mandatory that your app exposes a `manifest.json` file in the root dir wit | |||
| { | |||
| "name": "YourAppName", | |||
| "description": "A description of what your app do", | |||
| "iconPath": "myAppIcon.svg" | |||
| "iconPath": "myAppIcon.svg", | |||
| "providedBy": {"name": 'YourCompanyName', "url": 'https://yourcompanyname.io'} | |||
There was a problem hiding this comment.
" (double quotes) are required in json files
rmeissner
approved these changes
Sep 16, 2020
mmv08
added a commit
that referenced
this pull request
May 13, 2021
* Update README.md Co-authored-by: Mikhail Mikheev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safe App developers should also be advised to add the providedBy information to the manifest. While we do not yet expose this information to users, we do plan to do so in the future: safe-global/safe-react-apps#321