Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safe Apps] App Details #321

Open
lukasschor opened this issue Feb 4, 2020 · 11 comments
Open

[Safe Apps] App Details #321

lukasschor opened this issue Feb 4, 2020 · 11 comments
Labels
Feature 👑 New feature or request Safe Apps

Comments

@lukasschor
Copy link
Member

lukasschor commented Feb 4, 2020

Why do we need this?

As I user I want to be able to see who has developed a Safe App so that I can increase my trust in the Safe App or contact the developer in case there are any issues

What is this about?

See designs. Instead of the entire footer, we should only display the "i" icon in the bottom-right corner of the app. Clicking this icon would open the App Details modal.

image.png

image.png

In this modal, we should display information from the Safe App manifest

For "whitelisted" apps we should display:

  • Description
  • Developer
  • Website

For "non-whitelisted" apps (i.e. custom apps) we should display only Description as else the Developer/Website information could be spoofed.

@lukasschor lukasschor changed the title App Details App Footer Feb 4, 2020
@nicosampler
Copy link
Contributor

@lukasschor
Is the description composed only by Title and Description?
When the app is not provided by Gnosis, from where should we get that information?

@lukasschor lukasschor changed the title App Footer [Safe Apps] App Footer Feb 7, 2020
@lukasschor lukasschor added Feature 👑 New feature or request Minor and removed Major labels Mar 23, 2020
@nicosampler nicosampler self-assigned this Apr 15, 2020
@lukasschor lukasschor changed the title [Safe Apps] App Footer [Safe Apps] App Details May 12, 2020
@lukasschor lukasschor added Major and removed Minor labels May 12, 2020
@lukasschor lukasschor added Critical and removed Major labels Aug 27, 2020
@lukasschor
Copy link
Member Author

Might make sense to have the (i) in the bottom-left corner so that it does not interfere with the Intercom chat bubble.

@tschubotz
Copy link
Member

@posthnikova

@lukasschor
Copy link
Member Author

The App details are also planned to be visible from the Safe Apps overview page 5afe/safe-react#1294. I think this might remove the need for also displaying it in the individual app views.

@posthnikova
Copy link

The App details are also planned to be visible from the Safe Apps overview page 5afe/safe-react#1294.
I think this might remove the need for also displaying it in the individual app views.

There will be some transitional period when we won't have apps overview page. So for the old layout we need an info button on individual app screen. I propose we have a 'whitelisted' icon for apps which are whitelisted.

image

For the new layout the info button will be on apps overview page.

image

@tschubotz
Copy link
Member

I propose we have a 'whitelisted' icon for apps which are whitelisted.

What does "whitelisted" mean? Whitelisted as in "they appear in the interface since we added them?"

@posthnikova
Copy link

@tschubotz I mean added by us.

@tschubotz
Copy link
Member

@tschubotz I mean added by us.

Hmm. When adding a checkmark, we would need to also communicate what it means. In our terms, we follow the argumentation line "Safe apps are made by the respective developer, we did not audit them and don't vouch for "no bugs".

Hence I think we should not have this "checkmark" since we can't be liable for this.

@posthnikova
Copy link

So the difference of whitelisted apps from custom apps in the UI would be that whitelisted apps have 'Developer' and 'Website'. Custom apps would only have text description.

image

@posthnikova
Copy link

Question: do custom apps have description? Where does it come from?

image

When adding custom app, there is no field to enter desription.

image

@tschubotz
Copy link
Member

Question: do custom apps have description? Where does it come from?

@posthnikova The description is defined by the Safe app developer via the manifest.json. Example can be found there: https://ipfs.io/ipfs/QmTgnb1J9FDR9gimptzvaEiNa25s92iQy37GyqYfwZw8Aj/manifest.json

@tschubotz tschubotz removed the Critical label Oct 6, 2020
@johannesmoormann johannesmoormann transferred this issue from 5afe/safe-react Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature 👑 New feature or request Safe Apps
Projects
None yet
Development

No branches or pull requests

5 participants