-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Safe Apps] App Details #321
Comments
@lukasschor |
Might make sense to have the (i) in the bottom-left corner so that it does not interfere with the Intercom chat bubble. |
The App details are also planned to be visible from the Safe Apps overview page 5afe/safe-react#1294. I think this might remove the need for also displaying it in the individual app views. |
There will be some transitional period when we won't have apps overview page. So for the old layout we need an info button on individual app screen. I propose we have a 'whitelisted' icon for apps which are whitelisted. For the new layout the info button will be on apps overview page. |
What does "whitelisted" mean? Whitelisted as in "they appear in the interface since we added them?" |
@tschubotz I mean added by us. |
Hmm. When adding a checkmark, we would need to also communicate what it means. In our terms, we follow the argumentation line "Safe apps are made by the respective developer, we did not audit them and don't vouch for "no bugs". Hence I think we should not have this "checkmark" since we can't be liable for this. |
@posthnikova The description is defined by the Safe app developer via the |
Why do we need this?
As I user I want to be able to see who has developed a Safe App so that I can increase my trust in the Safe App or contact the developer in case there are any issues
What is this about?
See designs. Instead of the entire footer, we should only display the "i" icon in the bottom-right corner of the app. Clicking this icon would open the App Details modal.
In this modal, we should display information from the Safe App manifest
For "whitelisted" apps we should display:
For "non-whitelisted" apps (i.e. custom apps) we should display only Description as else the Developer/Website information could be spoofed.
The text was updated successfully, but these errors were encountered: