optimize: SDK bundle size by ~100kb #478
Conversation
🦋 Changeset detectedLatest commit: cdc7c61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
Hey, could you please revert all changes to the package.json and add a changeset instead? There's a comment above from the changeset bot that contains the instructions :) |
VladimirMikulic
force-pushed
the
optimize/sdk-bundle-size
branch
from
7db6ff1 to
5a24667
Compare
|
Appreciate the fast reply @mmv08. Changeset has been added. |
|
Hey all, just wondering what the latest was on this PR? |
|
@hammeiam PR waiting review. Feel free to subscribe to PR to get updates as we progress. |
|
when can we expect this to ship? it seems like it's been approved 2 weeks ago |
We use Safe Wallet SDK in our commercial Web3 application.
The main problem thus far has been huge bundle size.
After deeper investigation, I found out that inside SDK whole
etherspackage was imported.Moreover,
ethersitself isn't architected in the way so it can be tree shaken.Given that SDK only uses
ethersin a few places (message hashing and function data encoding), I've decided to migrate to alternativeviemwhich comes with much better TypeScript support and most importantly, the whole package is 3x smaller and optimized for tree shaking.After testing these changes in our production, we experienced a significant drop from 504kb to 359kb in bundle size.
I expect other apps to have similar result. (100 - 150kb drop depending on bundler configuration)